From owner-svn-src-head@freebsd.org Fri Nov 24 17:35:17 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFF1CDECD4C; Fri, 24 Nov 2017 17:35:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A3387D31D; Fri, 24 Nov 2017 17:35:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg0-x241.google.com with SMTP id z184so15707729pgd.13; Fri, 24 Nov 2017 09:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O17l1H1ftU9gd6A1d+CIhzSOmlslEU4f3IFSpWcxckk=; b=cwpW0Cgmgp7yUCh7V90NYlzD4jXJ6K3tdcKm8pTxBgw7IBuf+YMVupvqb5q5ls6vy4 zeY2LXL2MeKlfUQDyk7tdtpDBsut2qP3pG1laIppL9niYKviOud++7/Ae9AZUgmu/aTo 3g99prWhyS5akrgWUivGm5Lrq8BD/ZUsWhr/kbMwPyvHzqoXQvUzWT90EJtoiCD6AqmD i+wCsr6Hb2ZAumSuroPhHVQ2rrkRBbS9gMbeFU1uNS7tzG8YH3PqlWfCZi1QkRkRvP3a d3NzYvGIKGbLF8Y00VLreeJBaIW49T1urN+ii8v/lMaEXb6OitFbcLFio7jo1fG3Eebb TmKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=O17l1H1ftU9gd6A1d+CIhzSOmlslEU4f3IFSpWcxckk=; b=MEQPM4vgVVMDiG/3HffBagmtUseF0UVyqknAveQ8CiiHk/xcmuonakOZgeaNOlb5TN vabIJgUSzgTxkKJpvEnaf5Gq9UD5raT7Hoa3qULCSb8qr8ExSDCnmIZPrRLcdwuhr+YR eBLVmbl64zISWO2IQifFY4IiZDTMiFwABTTdMEKfDUSkFE3IVTAiK1gO0Ibrm61UktCQ enDgKiBH/bGz7V9PI0pQXFl8BGmwFvKfyzyTBBsfrw4gcUG4F+x6KnE9Lisxy2+ki7io k3F8NL2khXm/lK0B71F+IqmbibbOEKfzmr1H/3h8+wkkk0PoBtbt0czL/+77SEkCrJMP H/mw== X-Gm-Message-State: AJaThX4ok8bCfJiqbNs8KVCZcf/FPPkWm4UlrSe27o6gZezOtE4c/j2a +yVvN8IpjGpqXkGZe7w3qc0= X-Google-Smtp-Source: AGs4zMa9K2QqyRbA3lFbR5ESbp5rzFlmrZdDsp/zzlO4ifbB4Hpna+pdVqRTMEj73XAVVNhh6pLY7A== X-Received: by 10.101.101.154 with SMTP id u26mr21987324pgv.416.1511544916861; Fri, 24 Nov 2017 09:35:16 -0800 (PST) Received: from raichu (toroon0560w-lp140-01-69-159-38-22.dsl.bell.ca. [69.159.38.22]) by smtp.gmail.com with ESMTPSA id b10sm36353700pfj.20.2017.11.24.09.35.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Nov 2017 09:35:15 -0800 (PST) Sender: Mark Johnston Date: Fri, 24 Nov 2017 12:35:12 -0500 From: Mark Johnston To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... Message-ID: <20171124173512.GB1098@raichu> References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <20171124150044.GA94025@raichu> <20171124172239.GA1098@raichu> <5404fdf3-59f0-7bb0-772e-a9003671b0ef@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5404fdf3-59f0-7bb0-772e-a9003671b0ef@selasky.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 17:35:17 -0000 On Fri, Nov 24, 2017 at 06:29:25PM +0100, Hans Petter Selasky wrote: > On 11/24/17 18:22, Mark Johnston wrote: > > On Fri, Nov 24, 2017 at 06:09:25PM +0100, Hans Petter Selasky wrote: > >> On 11/24/17 16:00, Mark Johnston wrote: > >>> Are there non-trivial interoperability issues between mthca and the > >>> updated OFED stack? If so, could you describe them? If not, I would > >>> strongly prefer to retain the mthca driver, as Isilon still has plenty > >>> of hardware making use of it. > >> > >> Hi, > >> > >> There are no technical reasons except Mellanox hasn't focused on the > >> mthca driver in this upgrade. With little effort you should be able to > >> pull libmthca and the mthca driver from the mentioned sources and make > >> it work. > > > > In that case, could we please bring it back in to svn? It seems silly to > > remove a driver just because it's not being actively maintained: that > > isn't the bar for keeping drivers in FreeBSD, and I note that mthca is > > still present in Linux. If there is some work needed to get the kernel > > and userland components to compile again, I'm happy to do it; I just > > don't want to have to maintain an out-of-tree HCA driver when there's no > > good reason it can't stay in svn. > > > > Sure, but we probably want to put it into sys/dev/mthca instead of > sys/ofed/xxx . Ok. > Are you saying you want to pull it in yourself and make > it compile? I don't really *want* to, but I will if you don't. :)