From owner-freebsd-net@FreeBSD.ORG  Wed Sep  5 22:14:28 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9086016A417;
	Wed,  5 Sep 2007 22:14:28 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 02A3413C46A;
	Wed,  5 Sep 2007 22:14:27 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l85LZbf3097883;
	Wed, 5 Sep 2007 15:35:37 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <46DF2119.6030909@samsco.org>
Date: Wed, 05 Sep 2007 15:35:21 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
MIME-Version: 1.0
To: Jack Vogel <jfvogel@gmail.com>
References: <2a41acea0709051352n583b4724o359faaf29a1479d8@mail.gmail.com>
In-Reply-To: <2a41acea0709051352n583b4724o359faaf29a1479d8@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]);
	Wed, 05 Sep 2007 15:35:38 -0600 (MDT)
X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed
	version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
	Andre Oppermann <andre@freebsd.org>, John Baldwin <jhb@yahoo-inc.com>
Subject: Re: Thoughts on vlan filter
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2007 22:14:28 -0000

Jack Vogel wrote:
> I had an idea, I was debugging a problem on my new 10G driver a week back,
> and found I had the hardware vlan filter enabled by accident, this led me to
> wonder about supporting this hardware feature in the driver...
> 
> I have done some experimentation, and find that when the vlan device is
> configured, ultimately the SETMULTI ioctl will happen in my driver, this
> means I could add code that checks the trunk, finds there is a vlan and
> then sets the tag into the filter.
> 
> Any interest, or thoughts ya or nay about my doing this?
> 
> Cheers,
> 
> Jack

Overloading the SETMULTI ioctl is probably a bad idea for anything more
than a proof-of-concept.  From a cleanliness point of view, making the
software vlan module aware of this as a hardware offload capability and
able to control it via new ioctls sounds more reasonable.

Scott