From owner-freebsd-hackers@FreeBSD.ORG Sat Aug 27 01:38:30 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E4741065672 for ; Sat, 27 Aug 2011 01:38:30 +0000 (UTC) (envelope-from lichray@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3908E8FC08 for ; Sat, 27 Aug 2011 01:38:29 +0000 (UTC) Received: by gwb15 with SMTP id 15so4042194gwb.13 for ; Fri, 26 Aug 2011 18:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=MJafMWaguIkBmMFRLtkbpGq9dKEmsJ5aokYyBGJ0780=; b=VeSU4wYUHatr+YHD1M/5cHVfzLmTlrFH3CiQ3qtm1qqRub/3IN8rDtey7ho1ZQwsup /au7+sOhbWDeosj9OFr+M6qYeZ5bTNUnOpVrUqFXfuIw4dHRGTsoXjdjNmdeLrPYi4Zh 7cqoN7CPRkvDNNIam8l9CGhMIdUnuoV04sQiw= MIME-Version: 1.0 Received: by 10.231.75.77 with SMTP id x13mr3681217ibj.55.1314409108823; Fri, 26 Aug 2011 18:38:28 -0700 (PDT) Received: by 10.231.37.68 with HTTP; Fri, 26 Aug 2011 18:38:28 -0700 (PDT) In-Reply-To: References: <868vqt0xuc.fsf@gmail.com> <1313663436600-4711635.post@n5.nabble.com> <86hb5euofp.fsf@gmail.com> <20110823175133.GK18091@acme.spoerlein.net> Date: Fri, 26 Aug 2011 20:38:28 -0500 Message-ID: From: Zhihao Yuan To: Zhihao Yuan , Test Rat , freebsd-hackers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: [nvi-iconv]Call for test X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Aug 2011 01:38:30 -0000 A new version is uploaded. SVN users can download the patch at https://github.com/downloads/lichray/nvi2/nvi2-freebsd-2011-08-26-svn.diff.= gz A rcsid-free version (for git users) is available at https://github.com/downloads/lichray/nvi2/nvi2-freebsd-2011-08-26.diff.gz I did a "revision by revision" code review in this version, to make sure all FreeBSD changes on nvi are all considered. And, the catalogs are updated. Typically, Pavel Timofeev finished the Russian translation. I think the new nvi is stable enough, and I want to know what we should do next to get this into FreeBSD's base system, if it's possible. On Tue, Aug 23, 2011 at 3:33 PM, Zhihao Yuan wrote: > On Tue, Aug 23, 2011 at 12:51 PM, Ulrich Sp=C3=B6rlein wrote: >> On Thu, 2011-08-18 at 22:15:47 -0500, Zhihao Yuan wrote: >>> On Thu, Aug 18, 2011 at 9:26 PM, Test Rat wrote: >>> > timp writes: >>> > >>> >> Hi! >>> >> I just tried you patch on latest current with clang. >>> >> >>> >> [root@current64 /usr/src]# uname -a >>> >> FreeBSD current64 9.0-BETA1 FreeBSD 9.0-BETA1 #0: Thu Aug 18 03:56:4= 5 MSK >>> >> 2011 =C2=A0 =C2=A0 mox@current64:/usr/obj/usr/src/sys/GENERIC =C2=A0= amd64 >>> >> >>> >> [root@current64 /usr/src]# patch < ~/nvi2-freebsd-2011-08-17.diff >>> > [...] >>> >> =3D=3D=3D> usr.bin/vi (depend) >>> >> make: don't know how to make cl_bsd.c. Stop >>> >> *** Error code 2 >>> > >>> > Use `-p0' otherwise new directories won't be created. This is documen= ted >>> > in patch(1). And cl_bsd.c ended up in current directory (/usr/src) >>> > >>> > =C2=A0$ diffstat ~/nvi2-freebsd-2011-08-17.diff.gz | fgrep cl_bsd.c >>> > =C2=A0 contrib/nvi2/cl/cl_bsd.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0| =C2=A0346 +++ >>> >>> zzz... I always use -p0 but I did not know what it does... >>> >>> > >>> > Zhihao Yuan writes: >>> >> The patch will create contrib/nvi2, and it will not remove the unuse= d >>> >> contrib/nvi (patch(1) can not really remove files anyway). >>> > >>> > patch(1) can remove *empty* files with `-E', e.g. >>> > >>> > =C2=A0$ svn rm UPDATING >>> > =C2=A0$ svn di UPDATING | patch -E -d /usr/src >>> >>> Got it. But removing contrib/nvi with patch will just double the patch >>> size anyway. A svn rm will do it if some day the patch got committed. >> >> Since you already use github.com, why not clone >> https://github.com/freebsd/freebsd-head/ and do your work in a separate >> branch? People already using one of the github or gitorious clones can >> then easily download your branch and don't have to fight patch(1). >> > > FreeBSD's nvi code is frozen for a long time, so my patch should not > meet conflict. But since I touched rcsid recently, I'll upload > non-rcsid (git-friendly) patches recently. > >> just fyi, >> Uli >> > > > > -- > Zhihao Yuan, nickname lichray > The best way to predict the future is to invent it. > ___________________________________________________ > 4BSD -- http://4bsd.biz/ > --=20 Zhihao Yuan, nickname lichray The best way to predict the future is to invent it. ___________________________________________________ 4BSD -- http://4bsd.biz/