From owner-freebsd-current Sat Mar 1 14: 9:11 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7853237B405 for ; Sat, 1 Mar 2003 14:09:10 -0800 (PST) Received: from mail.liwing.de (mail.liwing.de [213.70.188.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AEB043FBD for ; Sat, 1 Mar 2003 14:09:06 -0800 (PST) (envelope-from rehsack@liwing.de) Received: (qmail 78269 invoked from network); 1 Mar 2003 22:09:03 -0000 Received: from stingray.liwing.de (HELO liwing.de) ([213.70.188.164]) (envelope-sender ) by mail.liwing.de (qmail-ldap-1.03) with SMTP for ; 1 Mar 2003 22:09:03 -0000 Message-ID: <3E612F7F.1090002@liwing.de> Date: Sat, 01 Mar 2003 23:09:03 +0100 From: Jens Rehsack Organization: LiWing IT-Services User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Juli Mallett Cc: current@freebsd.org Subject: Re: PATCH: type errors in src-tree References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Juli Mallett wrote: > * De: Jens Rehsack [ Data: 2003-03-01 ] > [ Subjecte: Re: PATCH: type errors in src-tree ] > >>Sorry for resending (3rd time), but I've found a small typo in the patch >>of sbin/atm/ilmid/ilmid.c > > >>- u_char **bufp; >>- Objid *objid; >>+ caddr_t *bufp; >>+ Objid *objid; > > > I understand (and think "good catch") on a number of other things, and > bogus type-width assumptions being caught, etc. But this? caddr_t > considered useless. Maybe you could clarify why you made the changes > to use caddr_t? Of course. Very often in ilmid.c the type caddr_t was used, and nearly the same count of 'const char *'s was used. I've searched the include files for caddr_t (core address) and found it defined as 'char *', so I decided to used commonly caddr_t - maybe later I check which of them could be changed into 'c_caddr_t' for being const. But You can of couse replace all 'caddr_t' which 'char *'. > Thanx, > juli. Jens To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message