Date: Thu, 20 Aug 2020 17:14:33 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r364427 - in head/sys: kern sys Message-ID: <202008201714.07KHEXuj007090@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Thu Aug 20 17:14:33 2020 New Revision: 364427 URL: https://svnweb.freebsd.org/changeset/base/364427 Log: Make devctl_queue_data_f and devctl_queue_data private. I thought we'd need them, but nobody is using them. Narrow the interface. This will facilitate changes in the future. Modified: head/sys/kern/subr_bus.c head/sys/sys/bus.h Modified: head/sys/kern/subr_bus.c ============================================================================== --- head/sys/kern/subr_bus.c Thu Aug 20 16:56:13 2020 (r364426) +++ head/sys/kern/subr_bus.c Thu Aug 20 17:14:33 2020 (r364427) @@ -607,7 +607,7 @@ devctl_process_running(void) * assumed that @p data is properly formatted. It is further assumed * that @p data is allocated using the M_BUS malloc type. */ -void +static void devctl_queue_data_f(char *data, int flags) { struct dev_event_info *n1 = NULL, *n2 = NULL; @@ -653,7 +653,7 @@ out: return; } -void +static void devctl_queue_data(char *data) { devctl_queue_data_f(data, M_NOWAIT); Modified: head/sys/sys/bus.h ============================================================================== --- head/sys/sys/bus.h Thu Aug 20 16:56:13 2020 (r364426) +++ head/sys/sys/bus.h Thu Aug 20 17:14:33 2020 (r364427) @@ -156,16 +156,13 @@ struct devreq { /** * devctl hooks. Typically one should use the devctl_notify - * hook to send the message. However, devctl_queue_data is also - * included in case devctl_notify isn't sufficiently general. + * hook to send the message. */ boolean_t devctl_process_running(void); void devctl_notify_f(const char *__system, const char *__subsystem, const char *__type, const char *__data, int __flags); void devctl_notify(const char *__system, const char *__subsystem, const char *__type, const char *__data); -void devctl_queue_data_f(char *__data, int __flags); -void devctl_queue_data(char *__data); struct sbuf; void devctl_safe_quote_sb(struct sbuf *__sb, const char *__src);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008201714.07KHEXuj007090>