From owner-svn-src-all@FreeBSD.ORG Wed Jun 19 14:14:20 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 09AC4102; Wed, 19 Jun 2013 14:14:19 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth4.wiscmail.wisc.edu (wmauth4.doit.wisc.edu [144.92.197.145]) by mx1.freebsd.org (Postfix) with ESMTP id 71A1B1468; Wed, 19 Jun 2013 14:14:19 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth4.wiscmail.wisc.edu by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MON008008QUGF00@smtpauth4.wiscmail.wisc.edu>; Wed, 19 Jun 2013 09:14:13 -0500 (CDT) X-Spam-PmxInfo: Server=avs-4, Version=6.0.2.2308539, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.6.19.140324, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-69-84.dsl.mdsnwi.sbcglobal.net [76.208.69.84]) by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MON00EUG8VOZR10@smtpauth4.wiscmail.wisc.edu>; Wed, 19 Jun 2013 09:14:13 -0500 (CDT) Message-id: <51C1BCB4.5090501@freebsd.org> Date: Wed, 19 Jun 2013 09:14:12 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130615 Thunderbird/17.0.6 To: Baptiste Daroussin Subject: Re: svn commit: r251843 - in head: contrib/dialog contrib/dialog/package contrib/dialog/package/debian contrib/dialog/po contrib/dialog/samples contrib/dialog/samples/copifuncs contrib/dialog/samples/i... References: <201306171028.r5HAStR2033639@svn.freebsd.org> <51BF0F0F.1080907@freebsd.org> <20130617133644.GB62733@ithaqua.etoilebsd.net> <51BF1121.9000408@freebsd.org> <20130617151734.GC62733@ithaqua.etoilebsd.net> In-reply-to: <20130617151734.GC62733@ithaqua.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 14:14:20 -0000 On 06/17/13 10:17, Baptiste Daroussin wrote: > On Mon, Jun 17, 2013 at 08:37:37AM -0500, Nathan Whitehorn wrote: >> On 06/17/13 08:36, Baptiste Daroussin wrote: >>> On Mon, Jun 17, 2013 at 08:28:47AM -0500, Nathan Whitehorn wrote: >>>> On 06/17/13 05:28, Baptiste Daroussin wrote: >>>>> Author: bapt >>>>> Date: Mon Jun 17 10:28:55 2013 >>>>> New Revision: 251843 >>>>> URL: http://svnweb.freebsd.org/changeset/base/251843 >>>>> >>>>> Log: >>>>> Update dialog to 1.2-20130523 >>>>> Level up WARNS >>>> This seems to have broken bsdinstall. In particular, it is no longer >>>> possible to get focus in the text input boxes in the partition editor's >>>> (sade/bsdinstall partedit) "Add Partition" or "Modify Partition" >>>> dialogs. Any chance you could try to figure out why? My Ncurses >>>> debugging skills are unfortunately not great. >>> I'm on it, yes, it seems like the dlg_forms is leaking the bindings from the >>> diskeditors form. >>> >>> I have a working patch but it is ugly. I'm trying to figure out the clean way to >>> do so. >>> >>> regards, >>> Bapt >> Thanks much! Please let me know if I can do anything to help. > I committed a workaround, I dicovered that the key on the Partition Editor > window are not the one we expect to be, I see no errors yet in libdialog code, > I'll continue investigating, but waiting for a proper fix, it is usable again. > > regards, > Bapt Thanks very much, both for this and the dialog update! I really appreciate it. -Nathan