From owner-cvs-all Thu May 30 15:55:24 2002 Delivered-To: cvs-all@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id 86D3537B408; Thu, 30 May 2002 15:55:19 -0700 (PDT) Received: from hades.hell.gr (patr530-a182.otenet.gr [212.205.215.182]) by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g4UMtFdO012115; Fri, 31 May 2002 01:55:16 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.3/8.12.3) with ESMTP id g4UMtDV3043077; Fri, 31 May 2002 01:55:13 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from charon@localhost) by hades.hell.gr (8.12.3/8.12.3/Submit) id g4UMtAR6043066; Fri, 31 May 2002 01:55:10 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Fri, 31 May 2002 01:55:08 +0300 From: Giorgos Keramidas To: John Baldwin Cc: "David O'Brien" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alfred Perlstein Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.h Message-ID: <20020530225508.GB29853@hades.hell.gr> References: <20020529234552.A62266@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-05-30 11:00 -0400, John Baldwin wrote: > On 30-May-2002 David O'Brien wrote: > > I believe a commit message should tell the why, not the way, the diff > > gives that. > > You can always follow up with an e-mail reply to explain what the > practical implications are, something like "This turns off the i386 #define, > you should only be using __i386__." or something for us ignorant masses > who don't know what the log message means. :) I think that is all Alfred > is asking for here. But then, if something is worth mentioning, why not keep in where our history is going... in the logs? - Giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message