From owner-freebsd-stable@FreeBSD.ORG Mon Jul 19 15:47:37 2010 Return-Path: Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 259B1106564A; Mon, 19 Jul 2010 15:47:37 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (lurza.secnetix.de [IPv6:2a01:170:102f::2]) by mx1.freebsd.org (Postfix) with ESMTP id 99A5D8FC1A; Mon, 19 Jul 2010 15:47:36 +0000 (UTC) Received: from lurza.secnetix.de (localhost [127.0.0.1]) by lurza.secnetix.de (8.14.3/8.14.3) with ESMTP id o6JFlJG9095497; Mon, 19 Jul 2010 17:47:34 +0200 (CEST) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.14.3/8.14.3/Submit) id o6JFlIwv095496; Mon, 19 Jul 2010 17:47:18 +0200 (CEST) (envelope-from olli) Date: Mon, 19 Jul 2010 17:47:18 +0200 (CEST) Message-Id: <201007191547.o6JFlIwv095496@lurza.secnetix.de> From: Oliver Fromme To: freebsd-stable@FreeBSD.ORG, jkim@FreeBSD.ORG, AndriyGapon In-Reply-To: <201007152001.o6FK1mGq088944@lurza.secnetix.de> X-Newsgroups: list.freebsd-stable User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX) (FreeBSD/6.4-PRERELEASE-20080904 (i386)) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.4 (lurza.secnetix.de [127.0.0.1]); Mon, 19 Jul 2010 17:47:34 +0200 (CEST) Cc: Subject: Re: 8.1-PRERELEASE: CPU packages not detected correctly X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2010 15:47:37 -0000 Oliver Fromme wrote: > Jung-uk Kim wrote: > > On Thursday 15 July 2010 01:56 pm, Andriy Gapon wrote: > > > on 15/07/2010 19:57 Oliver Fromme said the following: > > > > I patched topo_probe() so it calls topo_probe_0x4() after > > > > topo_probe_0xb() if cpu_cores is still 0. I think this > > > > is a better fallback procedure. With this patch, cpu_cores > > > > gets the value 4 which is the correct one, finally: > > > [...] > > > I think that your addition achieves this effect, perhaps just not > > > as explicitly as I would preferred. > > > > > > Jung-uk, what do you think? > > > > Yes, you're right. Please try new patch: > > > > http://people.freebsd.org/~jkim/mp_machdep2.diff > > Thank you! > > I will have access to that particular machine on Monday again, > so testing the new patch will have to wait until Monday. > But from looking at your patch it should have the same result > as my simpler patch, so it should work fine. As expected, the patch works perfectly fine. The cores are detected correctly: FreeBSD/SMP: Multiprocessor System Detected: 8 CPUs FreeBSD/SMP: 2 package(s) x 4 core(s) kern.sched.topology_spec: 0, 1, 2, 3, 4, 5, 6, 7 0, 1, 2, 3 4, 5, 6, 7 Thanks for fixing this! Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd Perl is worse than Python because people wanted it worse. -- Larry Wall