From nobody Wed Nov 17 04:28:59 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C6498189B3D8; Wed, 17 Nov 2021 04:29:49 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hv9255HlLz4VDG; Wed, 17 Nov 2021 04:29:49 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from localhost (gate.home.utahime.org [183.180.29.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: yasu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 82C957860; Wed, 17 Nov 2021 04:29:48 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Date: Wed, 17 Nov 2021 13:28:59 +0900 (JST) Message-Id: <20211117.132859.1875579380149864513.yasu@FreeBSD.org> To: danfe@freebsd.org Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo From: Yasuhiro Kimura In-Reply-To: References: <20211117.124452.1254944101155682425.yasu@utahime.org> X-Mailer: Mew version 6.8 on Emacs 29.0.50 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N From: Alexey Dokuchaev Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Date: Wed, 17 Nov 2021 03:58:30 +0000 > On Wed, Nov 17, 2021 at 12:44:52PM +0900, Yasuhiro Kimura wrote: >> ... >> PORTVERSION is the version used for the FreeBSD package. It will be >> automatically derived from DISTVERSION to be compatible with >> FreeBSD's package versioning scheme. > > To elaborate: right, so you set DISTVERSION when it's incompatible > with FreeBSD's package versioning scheme. Most of the time it is > compatible, so PORTVERSION should be used instead. I don't know > why this passage had been added to the PHB, I've asked a few times > but never got any meaningful answer. It looks totally backwards > to me, and it causes lots of needless churn on the ports repo. :( > > ./danfe OK, I understand that you are against to what is written and that you think PORTREVION should be used unless vendor's versioning scheme is imcompatible with that of ours. Whatever you think of it, however, currently it is written in PHB that DISTVERSION should be used. I have no preference about it. I just keep what is written. So I'm just confused to be complained about it to me. --- Yasuhiro Kimura