From nobody Fri Feb 27 02:29:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fMXN55PB1z6T7Xj for ; Fri, 27 Feb 2026 02:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fMXN50Gl6z40qs for ; Fri, 27 Feb 2026 02:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772159381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rsqH22kONSTzSsDBHRQcfVB2rJq5DHp9jFy2uC56kTg=; b=i99h07swvYPpuF0FB5eH18aDHFMx0y5vJxKrcw0isByXGzflrBftuwzGrm/3cC6wjxlNWG 5M+hIwh3kQY2OfTx8qHceOH/FvsTvXmtNDhOo8Pc7hz98MNSEReargguRq0iZgKWTRmRTi qqbXHc2vcmyCQ6ffI22Pba6g4KodiQG+ozsCUDq9OFWWZH1mZVOk1/X6LXp2P9XOXczVYS uRoFQQF494WAM334waLK1m7aDW7Zu5tD2ai5RaveIWTbLXuUNuKmmduyEgQH47WtG88WEb VfR4NZHUC9k2FHjRZ+t1wRRktDcEbJ/bHbxHxHFVdTttz8TOUELjqcCqAx4PSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772159381; a=rsa-sha256; cv=none; b=MkNcmAmuzuTlq5cJbS5tafOjB5zbjsrAa62C/6lIVg4Kef9ifqJJqXBicJhuo1kdmOpsxX DDnW/HqnzN9YqWJlYuSY6J4y0DkYgjcQ/j6sUfHKCUtCdLMlGCgpvR1gqW9SgZ2FXaE1rM UKhEEHwyajbFp9gl7IY8vUb2qLC+0BCTV+goTD+HoNma5I2djeEoZdblK/g0nBlebYt7MJ yPq+yFLMKSHXWGj/eXwukKjxgYZwxb4meN5Yf6nqMj2oJcjRHSkJyAeYyLOgjHJHDO4tCw /M/MBrTUk6RF1e0+TBCdKHNvlakYMf7HY0vY5Q1DIkePqiCWME0jPLaXCjsaXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772159381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rsqH22kONSTzSsDBHRQcfVB2rJq5DHp9jFy2uC56kTg=; b=wa2PJqjWStxG0KPfpxnO8ja69ifUBF6EQ799cG7H2jnCYl+HgrqX1GZAkWW5R4q8HWqM76 rJbBaisKnbX3ZFrwtxF3+JCRQBimXkkekeeRu6EKXO02RG6k2Sf8hzMdzntNCH4tq4VDID B9AWDRBUlZXrE4giJWPkSj3wv+mQLq7+QZERkq9siOiJta5zLfd4+DKLwJPCBJXfxJ1ifK /VSmIbdREdptmCTyseRa9gyqosAKUWeq+PIMEvNp0LAEdIBO5+6jAypSH5QUgh0M7+6Wzz 5voU5Yf4CqUeoCVPARZ6PCLWZ0zs3lotJeASCyBbxa0kOQ9/EQ+6IFc/uAbvIw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fMXN46y56zxR4 for ; Fri, 27 Feb 2026 02:29:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21383 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 27 Feb 2026 02:29:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 7c8425858944 - stable/15 - mt76: fix a check wrongly giving us random ether addresses all the time List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 7c8425858944a20c92164d4dd537ee7a8308072b Auto-Submitted: auto-generated Date: Fri, 27 Feb 2026 02:29:40 +0000 Message-Id: <69a10194.21383.3ce2c824@gitrepo.freebsd.org> The branch stable/15 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=7c8425858944a20c92164d4dd537ee7a8308072b commit 7c8425858944a20c92164d4dd537ee7a8308072b Author: Bjoern A. Zeeb AuthorDate: 2026-02-05 00:20:04 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-02-26 23:01:33 +0000 mt76: fix a check wrongly giving us random ether addresses all the time Do not cover the is_valid_ether_addr() check under CONFIG_OF. Unclear if this is an initial porting or a merging error before the driver hit the FreeBSD src tree. The end result was that we always got a random link-layer address, while the individual drivers may have setup phy->macaddr and this function would only overwride if given in device tree. Only if both, driver and and the OF backup, fail then go and use the random link-layer address. While here adjust printing the random link-layer address using a FreeBSD format specifier and not the unsupported Linux one. Fixes: 6c92544d7c97 Sponsored by: The FreeBSD Foundation (cherry picked from commit 3afe9e12fb331dc698ac62f3b918d82d768a2792) --- sys/contrib/dev/mediatek/mt76/eeprom.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sys/contrib/dev/mediatek/mt76/eeprom.c b/sys/contrib/dev/mediatek/mt76/eeprom.c index 1d5b95226a16..99e1bca3c19f 100644 --- a/sys/contrib/dev/mediatek/mt76/eeprom.c +++ b/sys/contrib/dev/mediatek/mt76/eeprom.c @@ -186,16 +186,19 @@ mt76_eeprom_override(struct mt76_phy *phy) err = of_get_mac_address(np, phy->macaddr); if (err == -EPROBE_DEFER) return err; +#endif if (!is_valid_ether_addr(phy->macaddr)) { -#endif eth_random_addr(phy->macaddr); dev_info(dev->dev, +#if defined(__linux__) "Invalid MAC address, using random address %pM\n", phy->macaddr); -#if defined(CONFIG_OF) - } +#elif defined(__FreeBSD__) + "Invalid MAC address, using random address %6D\n", + phy->macaddr, ":"); #endif + } return 0; }