From owner-svn-src-all@FreeBSD.ORG Sat Dec 17 21:44:45 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1D87106566B; Sat, 17 Dec 2011 21:44:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 5861B8FC0A; Sat, 17 Dec 2011 21:44:44 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id pBHLie8E080635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Dec 2011 23:44:40 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id pBHLiec1061578; Sat, 17 Dec 2011 23:44:40 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id pBHLieRG061577; Sat, 17 Dec 2011 23:44:40 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 17 Dec 2011 23:44:40 +0200 From: Kostik Belousov To: Dimitry Andric Message-ID: <20111217214440.GB50300@deviant.kiev.zoral.com.ua> References: <201112172137.pBHLbMAo077674@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hjFJOZjrGMhmIgO+" Content-Disposition: inline In-Reply-To: <201112172137.pBHLbMAo077674@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228663 - head/usr.sbin/lpr/filters X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 21:44:46 -0000 --hjFJOZjrGMhmIgO+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 17, 2011 at 09:37:22PM +0000, Dimitry Andric wrote: > Author: dim > Date: Sat Dec 17 21:37:21 2011 > New Revision: 228663 > URL: http://svn.freebsd.org/changeset/base/228663 >=20 > Log: > In usr.sbin/lpr/filters/lpf.c, use a less obtuse way of clearing the > buffer, that also avoids warnings. > =20 > MFC after: 1 week >=20 > Modified: > head/usr.sbin/lpr/filters/lpf.c >=20 > Modified: head/usr.sbin/lpr/filters/lpf.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.sbin/lpr/filters/lpf.c Sat Dec 17 20:53:06 2011 (r228662) > +++ head/usr.sbin/lpr/filters/lpf.c Sat Dec 17 21:37:21 2011 (r228663) > @@ -55,6 +55,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > =20 > #define MAXWIDTH 132 > #define MAXREP 10 > @@ -115,7 +116,7 @@ main(int argc, char *argv[]) > acctfile =3D cp; > } > =20 > - for (cp =3D buf[0], limit =3D buf[MAXREP]; cp < limit; *cp++ =3D ' '); > + memset(buf, ' ', sizeof(buf)); > done =3D 0; buf is two-dimensional array. This change looks wrong. > =20 > while (!done) { --hjFJOZjrGMhmIgO+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7tDUgACgkQC3+MBN1Mb4hDeACfTMLTK2w88UwQVbonsFMGh9up UHkAnAmvsitP7yzHuo7O3opwmADgKf/P =xkOO -----END PGP SIGNATURE----- --hjFJOZjrGMhmIgO+--