From owner-cvs-src@FreeBSD.ORG Mon Jul 3 06:13:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9615916A403; Mon, 3 Jul 2006 06:13:11 +0000 (UTC) (envelope-from nate@root.org) Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C0AC443E6; Mon, 3 Jul 2006 06:13:11 +0000 (GMT) (envelope-from nate@root.org) X-ORBL: [71.139.63.87] Received: from [10.0.5.51] (ppp-71-139-63-87.dsl.snfc21.pacbell.net [71.139.63.87]) by ylpvm01.prodigy.net (8.13.7 out spool5000 dk/8.13.7) with ESMTP id k636D6G3001978; Mon, 3 Jul 2006 02:13:09 -0400 Message-ID: <44A8B572.6030503@root.org> Date: Sun, 02 Jul 2006 23:13:06 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.2 (X11/20060501) MIME-Version: 1.0 To: Pyun YongHyeon References: <20060703025355.AA9CA16A62D@hub.freebsd.org> In-Reply-To: <20060703025355.AA9CA16A62D@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mii acphy.c amphy.c bmtphy.c brgphy.c ciphy.c e1000phy.c exphy.c inphy.c lxtphy.c mlphy.c nsgphy.c nsphy.c pnaphy.c qsphy.c rgephy.c rlphy.c ruephy.c tdkphy.c tlphy.c ukphy.c xmphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2006 06:13:11 -0000 Pyun YongHyeon wrote: > yongari 2006-07-03 02:53:40 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mii acphy.c amphy.c bmtphy.c brgphy.c ciphy.c > e1000phy.c exphy.c inphy.c lxtphy.c > mlphy.c nsgphy.c nsphy.c pnaphy.c qsphy.c > rgephy.c rlphy.c ruephy.c tdkphy.c > tlphy.c ukphy.c xmphy.c > Log: > Replace hard-coded magic constants to system defined constants > (BUS_PROBE_DEFAULT, BUS_PROBE_GENERIC etc). > There is no functional changes. > > Reviewed by: oleg, scottl Actually, there are functional changes. Whether those changes are ok or not, I don't know. > --- src/sys/dev/mii/acphy.c:1.17 Fri Sep 30 19:39:27 2005 > +++ src/sys/dev/mii/acphy.c Mon Jul 3 02:53:39 2006 > @@ -132,7 +132,7 @@ > } else > return (ENXIO); > > - return (0); > + return (BUS_PROBE_DEFAULT); > } > > static int This means probe() will be called multiple times to allow bidding for the device. Is that ok for this and other devices? -- Nate