From owner-svn-src-all@freebsd.org Sat Mar 23 04:33:26 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE81B155E5E3; Sat, 23 Mar 2019 04:33:26 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4962675F3B; Sat, 23 Mar 2019 04:33:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 7YLLh3BrJLdsa7YLMhtYZG; Fri, 22 Mar 2019 22:33:17 -0600 X-Authority-Analysis: v=2.3 cv=G9Zi7Os5 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=NTGMnVQrEZIA:10 a=Wi8YH2NmAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=TU3Kt4leLilQqZbvHCoA:9 a=CjuIK1q_8ugA:10 a=dHv3ApjLk2iqpRL9FmoU:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id B1434107; Fri, 22 Mar 2019 21:33:14 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x2N4XEjR013862; Fri, 22 Mar 2019 21:33:14 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x2N4XEni013859; Fri, 22 Mar 2019 21:33:14 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201903230433.x2N4XEni013859@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Hiroki Sato cc: cy@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345400 - in head/libexec/rc: . rc.d In-Reply-To: Message from Hiroki Sato of "Sat, 23 Mar 2019 12:58:53 +0900." <20190323.125853.93885646440204179.hrs@allbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 22 Mar 2019 21:33:14 -0700 X-CMAE-Envelope: MS4wfJ2dYZArhCduDKUNINTaas/IZZNlJVkZx7RwmGsjvxq82izLtArHGRgBHeaUj1xok0cNYlbugwkv+fvmjYAthFmiR+7/xGrUUDMcRxgr45Q+HP/3tE/k 5VC6yI3h6xd8JtTtDwxRj5yODjfKOhQSEoSCy6EIavvR/UW5yxUIl6jeKRNvzpPCrQF2i7BFiWxBTNbb1KMdhkG/rs8NByyRjMuakBHNcVU1Wsg6kj2tqvQr QU0j6bH4QFvUpn9qE6VBlEoYCRisK23XNeuE385xgHx9ZXoXkkxaO45S/EK7qE/OCYA9eOjOJPD+NCXsF7AQVA== X-Rspamd-Queue-Id: 4962675F3B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.96 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; IP_SCORE(-2.37)[ip: (-6.54), ipnet: 64.59.128.0/20(-2.94), asn: 6327(-2.26), country: CA(-0.09)]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.88)[-0.880,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[13.134.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Mar 2019 04:33:27 -0000 In message <20190323.125853.93885646440204179.hrs@allbsd.org>, Hiroki Sato writ es: > ----Security_Multipart(Sat_Mar_23_12_58_53_2019_110)-- > Content-Type: Text/Plain; charset=us-ascii > Content-Transfer-Encoding: 7bit > > Cy Schubert wrote > in <201903220130.x2M1Uq0p042374@repo.freebsd.org>: > > cy> Author: cy > cy> Date: Fri Mar 22 01:30:51 2019 > cy> New Revision: 345400 > cy> URL: https://svnweb.freebsd.org/changeset/base/345400 > cy> > cy> Log: > cy> Add rc.d support for ippool(8). > cy> > cy> I've been using ippool at my site for approximately two years. It's > cy> about time this was committed. > cy> > cy> PR: 218433 > cy> MFC after: 2 weeks > > cy> Added: head/libexec/rc/rc.d/ippool > cy> ========================================================================= > ===== > cy> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > cy> +++ head/libexec/rc/rc.d/ippool Fri Mar 22 01:30:51 2019 (r34540 > 0) > cy> @@ -0,0 +1,40 @@ > cy> +#!/bin/sh > cy> +# > cy> +# $FreeBSD$ > cy> +# > cy> + > cy> +# PROVIDE: ippool > cy> +# REQUIRE: FILESYSTEMS > cy> +# BEFORE: ipfilter > cy> +# KEYWORD: nojail > cy> + > cy> +. /etc/rc.subr > cy> + > cy> +name="ippool" > cy> +desc="user interface to the IPFilter pools" > cy> +rcvar="ippool_enable" > cy> +load_rc_config $name > cy> +start_cmd="ippool_start" > cy> +stop_cmd="${ippool_program} -F" > cy> +reload_cmd="ippool_reload" > cy> +extra_commands="reload" > cy> +required_files="${ippool_rules}" > cy> +required_modules="ipl:ipfilter" > cy> + > cy> +ippool_start() > cy> +{ > cy> + if [ -r "${ippool_rules}" ]; then > cy> + echo "Loading IP Pools." > cy> + ${ippool_program} -f ${ippool_rules} ${ippool_flags} > cy> + fi > > This conditional is redundant. $required_files will check > readability of $ippool_rules. > > And if you want to add a flag, use of precmd is the right way like > the following: > > ---- > start_precmd="ippool_start_precmd" > > ippool_start_precmd() > { > rc_flags="-f ${ippool_rules} ${rc_flags}" > } > ---- Thanks for this. Fixed. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.