From owner-svn-src-all@freebsd.org Thu Dec 17 14:29:06 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87FB7A49147 for ; Thu, 17 Dec 2015 14:29:06 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 282941622 for ; Thu, 17 Dec 2015 14:29:05 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x234.google.com with SMTP id l126so24170681wml.1 for ; Thu, 17 Dec 2015 06:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=llAIL4mBWhxWGeajEhCz/ulHXpQrR4ph802sZkO754o=; b=KAti9hR/oks49G7oevBRcNkcHkkrVcUQAp9tjIxzzHHQkx9EUxETCw1ClutMedkMy8 AWJhEQ8QQmaLnskqinerytkjt23sIfbyR8b5sRIcfL/4mfksWpkV+Pa78y3iuHd28zwi 3PWradN6P1JtWGiQ37Y+rBDX2Bd6aRbyF1QloyEJgTkS8rKoK4TRe1hkAWbpmwx/K7JX blTyjaV4t8MFdJCzIMNNZH67M+SdlHsn9Ooc+2agW0UMNid6GrCs/r69lpzKpBxRJGdi K6KW/V64vVFODdez1XA+2EkVe7adnS8zx4eiJfwrKUlbIHyw4p1c50n5co0IK4weA6dZ zxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=llAIL4mBWhxWGeajEhCz/ulHXpQrR4ph802sZkO754o=; b=W7dBB2CwinuayfNiIH84/Ubyy3J601cvutbHN8Ew/S8a98FedIuGsPxvJzdrq4VIdV JI+hGMu1TyglIlurggCwJAoNl6bv7Bt2J6PYvD3jnrTTGAs0s13tGaJs6ddtr7VbK+03 XIHwWsMrM+BT3gDWeportLUh5DapBlTZ+/vNtrulwInr7DnLJOGghkUFJnQ5oTDffBIA aPbtTwaKedRYfI4NpMs4pss1zXwNFCWsc79i3x+erDW61CzP3Rfng81po3gwJyo4EIe4 A4TkSaUEh3gkxwPdbYmEk8KgS8MU3QftP8ZiEX8FGhLPkyApSQFalGx+z9gi4IcxnC10 0M7Q== X-Gm-Message-State: ALoCoQkEAXYKYbClxF7xgZK6AjuSC8Sf14Bsin6wtRtFL7PH0C98v7etaXDp3OvyRGim+Et3Tp88JCtnWT0QlRmFuPuFhux2aA== X-Received: by 10.194.2.193 with SMTP id 1mr58445553wjw.26.1450362544052; Thu, 17 Dec 2015 06:29:04 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id jt9sm10695033wjc.38.2015.12.17.06.29.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 17 Dec 2015 06:29:02 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r292379 - in head/sys: netinet netinet6 To: Gleb Smirnoff References: <201512162226.tBGMQSvs098886@repo.freebsd.org> <20151217003824.GG42340@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5672C6AE.7070407@freebsd.org> Date: Thu, 17 Dec 2015 14:29:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151217003824.GG42340@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 14:29:06 -0000 Hey Gleb, sorry I didn't wait for your review, but I did ask around on what the timeout for this would be and was informed 2 weeks and as it had been over a month, with quite a bit of feedback from others in the area, all of which had been addressed I thought that was reasonable. A simple reply of "I do intend to review but don't have time yet so please wait" I think would be useful in these types of situations, as I know everyone's busy but its impossible to know what others are thinking. Clearly the MTU think was just a silly mistake, which I backed out instantly so lets not be to harsh on that one ;-) With regards MAINTAINERS, is there any sort of automation which could alert on this (pre-commit) hook maybe as I'm sure that would be helpful as a reminder. I would definitely like to understand more about your concerns and learn from your knowledge in this area, so thanks for that offer, and while it does sound unforgiving I totally understand where you're coming from. Hopefully together we can bring this to a satisfactory conclusion as I would hate for both carp and lagg to stay as broken, 2 years is long enough :D Regards Steve On 17/12/2015 00:38, Gleb Smirnoff wrote: > Steven, > > I'm sorry that wasn't able to review D4111 in time, but I have > very strong concerns against r292275. And r292379 doesn't > improve situation. I am asking you to back out both patches, > and then we can get together back to the problem. The 156226 > bug was sitting for 2 years in the bugzilla for a reason. It > is a not "low hanging fruit" like koobs@ says. > > I'm sorry if I sound unforgiving, but you got a very bad commit > record in this area. You committed r290403 to ip_carp.c which > "added MTU support to carp interfaces", and that was after 4 YEARS > of carp(4) being not an interface. So, I assume you doesn't > have a good understanding of the current state of the stack, > direction it is developed and things that can be done and > can not (including DELAY() in callout(9). > > Note, that the MAINTAINERS file still lists me for ip_carp.c, > and you didn't wait for my review. yet another reason to ask > for backout. > > I understand that you got a product at work that needs to > have problem fixed. I'm glad that you got a patch that works > it around. But that doesn't mean the patch should immeditely > be dumped in head with a threat of soon MFC. >