Date: Wed, 9 May 2018 08:29:22 -0700 From: Ultima <ultima@ultimasbox.com> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469172 - head/net/guacamole-server Message-ID: <CANJ8om77C-nRfm5d=eO_mNDzvJPqwkOazDpYxqY2xGSS5xN0Tw@mail.gmail.com> In-Reply-To: <y3gt-w9ov-wny@FreeBSD.org> References: <201805060046.w460kACv084700@repo.freebsd.org> <y3gt-w9ov-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey Jan, Thanks for the patch. I have been struggling to get adequate time to find the proper flag to fix the depreciation build failures. Can you please go ahead and commit it? You have my blessing. =D Best regards, Richard Gallamore On Wed, May 9, 2018 at 12:49 AM, Jan Beich <jbeich@freebsd.org> wrote: > Richard Gallamore <ultima@FreeBSD.org> writes: > > > Author: ultima > > Date: Sun May 6 00:46:09 2018 > > New Revision: 469172 > > URL: https://svnweb.freebsd.org/changeset/ports/469172 > > > > Log: > > * Remove GUACENC from defaults > > > > Guacamole-server is not compatible with Ffmpeg > > version 4.0+. Will readd once fixed upstream. > > Does the following patch help? See build log: https://ptpb.pw/6js3 > > In general, allowing ports to use -Werror is a bad idea as it tends to > bring misery during compiler or dependency upgrades. It should probably > be stripped like -O3 -funroll-loops are. However, more specific warnings > like -Werror=implicit-function-declaration -Werror=return-type are fine. > > Besides, FreeBSD wasn't the first to update to FFmpeg 4.0. Arch Linux > will join the fray soon. > https://repology.org/metapackage/ffmpeg/history > https://www.archlinux.org/todo/ffmpeg-40/ > > diff --git net/guacamole-server/Makefile net/guacamole-server/Makefile > index 51148ef23a4c..978e85da0942 100644 > --- net/guacamole-server/Makefile > +++ net/guacamole-server/Makefile > @@ -3,7 +3,7 @@ > > PORTNAME= guacamole-server > DISTVERSION= 0.9.14 > -PORTREVISION= 2 > +PORTREVISION= 3 > CATEGORIES= net > > MAINTAINER= ultima@FreeBSD.org > @@ -39,7 +39,7 @@ SUB_LIST= GUACD_USER=${USERS} \ > GUACD_GROUP=${GROUPS} > > OPTIONS_DEFINE= GUACENC NLS SSL WEBP > -OPTIONS_DEFAULT= RDP SSH SSL VNC VORBIS PULSEAUDIO WEBP > +OPTIONS_DEFAULT= GUACENC PULSEAUDIO RDP SSH SSL VNC VORBIS WEBP > OPTIONS_GROUP= SP AUDIO > OPTIONS_GROUP_SP= RDP SSH VNC > OPTIONS_GROUP_AUDIO= VORBIS PULSEAUDIO > @@ -51,10 +51,10 @@ RDP_DESC= RDP protocol support > SP_DESC= Supported Protocols > VNC_DESC= VNC protocol support > > -GUACENC_BROKEN= fails to build with ffmpeg 4.0 > GUACENC_CONFIGURE_ENABLE= guacenc > GUACENC_CONFIGURE_WITH= libavcodec libavutil libswscale > GUACENC_LIB_DEPENDS= libavcodec.so:multimedia/ffmpeg > +GUACENC_CFLAGS= -Wno-error=deprecated # > avcodec_register_all > NLS_USES= gettext-runtime > PULSEAUDIO_CONFIGURE_WITH= pulse > PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANJ8om77C-nRfm5d=eO_mNDzvJPqwkOazDpYxqY2xGSS5xN0Tw>