From nobody Mon Aug 18 18:31:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5Lsh0HmVz64K9S for ; Mon, 18 Aug 2025 18:32:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5Lsg4p29z3Q8B for ; Mon, 18 Aug 2025 18:32:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45a1b004a31so31143845e9.0 for ; Mon, 18 Aug 2025 11:32:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755541925; x=1756146725; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p2zm7PlTHHs3bzZdTLYk7B0ta5m/aMZ0Q2+rZ/2LxKE=; b=gKEfKflE/pdOYlbJi4ML9Tm+26eEhAfN4FNE7nZHQdf4lZo4aaJLcf7OTB/sBwBtzR 4le3RDkEB6tVHmxI2wone/N5Nssa2gkqdt/uJlvsT/EVWVAkzMh8yGDLht6HniCGKeez i1xMjVol4bBRyE+xMAQzHlcMQhTDWmn8j5l+xJBd9pd0G7yPaPRqnMf6rArOKP9HYhrW Lzo79GuIcR+o/rT9g3lLx9FD2QL3qj6Vq8yagh08sx+Rq3s4jmwI8Dtnx6J8fj7j6rGJ +u9vS4gyKelqm+iXvJQ9+vS5NJcfuB+yEtnJbxYVmG/Szoef+G3HcnTke6PMZ4EYJmZx 4SjQ== X-Forwarded-Encrypted: i=1; AJvYcCXoXq3db3byeD8MyIXCq3Fa4b1sVxCUhvYtMJHkVjcYnU+1VMmaV/x9cZ+7rfaafTHya4iqtQc+N5JHG4cufuAg4Ob6qw==@freebsd.org X-Gm-Message-State: AOJu0YwnlX4cPpNoQp9gI2yRhLMX44KkeQODFvMcZYHvnTYKfPvO9+Pw 07iTpfw8gV42sphTaCz89cSo6cPIPcnfYB4pNp6wyocXejIE/qOwx5S6NWLK51fZW7w= X-Gm-Gg: ASbGncvjxM3Lso8r+b7bTwuRWxLq89UMwenYg7J0nt2LC5BgKz+ZP4l9afPGSxy7Lbg jWJncOqOCo1YDhR/ktvuTgfCngeQw67d3lK2drT77EQtAh75gFai76EFcnQayv4netdhq4y/3EG h/vPhjrLsNkvQ9W+G0XUU/o00fVduRj4qBbvPwFVAaTZXZPlaftLPIS/sXaVKz4fe2lX+9NU3JO Wpad7woWo4d9+nBBBByeGRCjwMbe0Mv7skTj9TDrQaLEk90kIXPHOIiSbVJcFwaLIXK/Zfw5My8 5vyw7ZH1N/okqbVfsurPK6FIEsdOUFr2CGfgD+/9XbF/T8wPPWoQIoMR5AOGD/RQifYJ7CCnVJG wfBAqo0gel3W4XoLwQdVTTTsuU+OqdGUCTR8U6kvGy0l6xKJi/8tXHi2pCh7x9YVR9ZCy X-Google-Smtp-Source: AGHT+IE0eF2T9IPLd6E4sTSDO8iVD+6f8OL8+asdE0T9tJ7tGGM1bc5J7IelMvjm0FsdNQyvHFif9A== X-Received: by 2002:a05:600c:19cd:b0:456:a1b:e906 with SMTP id 5b1f17b1804b1-45b4367b78amr428645e9.33.1755541925100; Mon, 18 Aug 2025 11:32:05 -0700 (PDT) Received: from smtpclient.apple (global-184-7.n-1.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c07487a009sm477684f8f.11.2025.08.18.11.32.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Aug 2025 11:32:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: c6778f3a4423 - main - Makefile.libcompat: Tweak krb5 compat dirs From: Jessica Clarke In-Reply-To: <6820006a-8621-40b3-9e3e-a21a98347829@FreeBSD.org> Date: Mon, 18 Aug 2025 19:31:53 +0100 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <698440A1-566C-4A7A-A301-9BC89825CC3F@freebsd.org> References: <202508170227.57H2R862074953@gitrepo.freebsd.org> <77e12d8d-3634-4d6e-bf17-220eca030eb0@FreeBSD.org> <6820006a-8621-40b3-9e3e-a21a98347829@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c5Lsg4p29z3Q8B On 18 Aug 2025, at 19:28, John Baldwin wrote: > > On 8/18/25 11:32, Lexi Winter wrote: >> John Baldwin: >>> On 8/16/25 22:27, Lexi Winter wrote: >>>> Makefile.libcompat: Tweak krb5 compat dirs >>> >>> Why not just move these directories over to krb5/lib? >> i was planning to discuss this with Cy, but the reason is that some of >> the libraries in util/ require compile_et, which is also in util/, so >> it's more complicated than just moving the libraries to lib/. > > As noted on IRC, I think this would be a no-op. Today krb5/Makefile > builds util before lib, so moving items from the end of krb5/util/Makefile > to the start of krb5/lib/Makefile should preserve the same relative > order (I'm assuming changing the relative position of krb5/include > shouldn't matter). Libraries are built before executables, so ordering between them in subdirectories is often irrelevant, and libraries require the *bootstrap* compile_et, not the one built for the target (even if the same architecture). There should be no need for any of this, and it just makes things more annoying to get right for libcompat. Jessica