From owner-freebsd-arch@freebsd.org Fri May 15 19:58:07 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE9192FEF2D for ; Fri, 15 May 2020 19:58:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49NzjW54bfz4N48; Fri, 15 May 2020 19:58:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 9D2C51DD86; Fri, 15 May 2020 19:58:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f182.google.com with SMTP id m44so3043479qtm.8; Fri, 15 May 2020 12:58:07 -0700 (PDT) X-Gm-Message-State: AOAM530kCAgMhnKdmwxmN+f4TIBgyzOdldZFlgLzpcu2h8Mje9MJXXm2 TNuz3BPwDBHW0gQ+t7zurQCuo75pkPuoIMwbJg4= X-Google-Smtp-Source: ABdhPJyzHxN05qfRun2yeN2XfmsWfM51TwyFz+KUPJVs+Hq4VsMOKYxiIM0KTNzZ7YdQYtHaC5h5ZRO48v6n21+NBMM= X-Received: by 2002:ac8:5353:: with SMTP id d19mr5194528qto.310.1589572687272; Fri, 15 May 2020 12:58:07 -0700 (PDT) MIME-Version: 1.0 References: <202005151944.04FJiXmr087925@gndrsh.dnsmgr.net> In-Reply-To: <202005151944.04FJiXmr087925@gndrsh.dnsmgr.net> From: Kyle Evans Date: Fri, 15 May 2020 14:57:53 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [HEADSUP] Disallowing read() of a directory fd To: "Rodney W. Grimes" Cc: "freebsd-arch@freebsd.org" , Poul-Henning Kamp Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 19:58:07 -0000 On Fri, May 15, 2020 at 2:44 PM Rodney W. Grimes wrote: > > > On Thu, May 14, 2020 at 1:26 PM Kyle Evans wrote: > > > > > > Hi, > > > > > > This is a heads up, given that I'm completely flipping our historical > > > behavior- I intend to commit this review in a couple days' time > > > without substantial objection: https://reviews.freebsd.org/D24596 > > > > > > > Note that the review has been updated to reflect feedback received > > through the course of this discussion. The current version, as of the > > time of writing, instead adds a security.bsd.allow_read_dir > > (defaulting to off) that will allow the system root (*not* jailed > > root) the ability to read(2) a directory if the filesystem supports > > it. A new priv(9), PRIV_VFS_READ_DIR has been added so that anyone > > interested in expanding the scope of the sysctl beyond the system root > > is welcome to implement a MAC policy for it. > > > > rgrimes@ and phk@ have been specifically invited to the review as > > representatives of those opposing the original change, but of course > > anyone is free to add themselves and/or simply chime in with > > constructive objections. > > I did not oppose the change, just asked that the change be knobbed > so that the few rare ones of us that do use this ability do not > have to jump through hoops when we need it to fix a problem. > Apologies, I did not intend to misrepresent your position -- I had interpreted your post as "objection with a path to acceptance" and followed it to that end since I was providing a revised version that aimed to also appeal to your criteria. Thanks, Kyle Evans