From owner-svn-ports-all@freebsd.org Tue Dec 12 19:17:14 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEF36E80DB4; Tue, 12 Dec 2017 19:17:14 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-ua0-x234.google.com (mail-ua0-x234.google.com [IPv6:2607:f8b0:400c:c08::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 660D76D240; Tue, 12 Dec 2017 19:17:14 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-ua0-x234.google.com with SMTP id w47so15150228uah.3; Tue, 12 Dec 2017 11:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fazzE1TnWQFOYGq7jnddyJsEKTJrTjYxVTfgCVfYOGw=; b=UCkMbo1lpbqOrz4KA0R060rSEQ7hXJhC+qKOTC1nmjSSrc573zdtOocDXQ8f960c5O /cn0IHCDyleWLJqKHW3v102ySUHx6e4qYZh/HabjYjR6p4lzCeUatcAuaR0StWZgvTfi 3I0uZyHF6TxOGreq/m9LC/4RoonM0jZtYVrzetRHmrSPcprmjv74qF2IeHDyp2T4P9jU MYqtj1b0aLqUNtRgJcb74iWxw4R+OL5drqM4cjZfzsSSQDCAjZ3NU0GAurnImGif4T/c tkqgy40cn9IEggllnnMQreC956NH4UTCpLxn4KmF3v7ZTw4Il+RXZmmwLltmwBSFJUbu w9jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fazzE1TnWQFOYGq7jnddyJsEKTJrTjYxVTfgCVfYOGw=; b=NIAjjF2d9pGHVJrT+vE0OT+PxGCKBdOeAKxHkPsYEJrhgZEJv5T6yNFRnu3CM9iGvz vfMmzQibuxtgNDb7uQNPaVeehBGyiUB1z2uzNdSfIZyqVzNPyqSXcyeZ5Hu63Q2kQsjo UP1LB6GFBDhcMmakODwU/u0LFjt2obnhHdNMvrGZEpwi+8wRcogJDDhEjUmc4Jsw7IFi Podv7qTTC5zLiFBSeLaPsfDl4C4T0PR2hOwMXxN++093y9FlBhBOfMUPlCFxfABNyP8Y TwuTS9hL6JRPZ0YYW/ZI5a9fa+FSlaP4tENYK5B2ALXT/GZPt0+HQl8JHPLQPPsTNo03 uM9Q== X-Gm-Message-State: AKGB3mJbBIbjkwZHNg3DOXRy//kxsKcT0jkQoAU153/rQ5EMbD7E/h+e BV0/mHIK4B5xzKFLDi1Ucz0Yjqd31G/huPi8qu4Dfw== X-Google-Smtp-Source: ACJfBos0G5d4NAycgJZYpq9JS25ITKBFOy6AK/59DNEhmm1AYhcPMF31jzTsw7FcBlkp/LIKYGZEZV374GzqX/iAPik= X-Received: by 10.159.36.248 with SMTP id 111mr5404119uar.187.1513106233047; Tue, 12 Dec 2017 11:17:13 -0800 (PST) MIME-Version: 1.0 References: <201712121231.vBCCVBLY044497@repo.freebsd.org> In-Reply-To: <201712121231.vBCCVBLY044497@repo.freebsd.org> From: Ben Woods Date: Tue, 12 Dec 2017 19:17:02 +0000 Message-ID: Subject: Re: svn commit: r456124 - head/Mk/Uses To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:17:14 -0000 On Wed, 13 Dec 2017 at 1:31 am, Mathieu Arnold wrote: > Author: mat > Date: Tue Dec 12 12:31:10 2017 > New Revision: 456124 > URL: https://svnweb.freebsd.org/changeset/ports/456124 > > Log: > Add a DEV_WARNING about some hypotetical case. > > Sponsored by: Absolight > > Modified: > head/Mk/Uses/python.mk > > Modified: head/Mk/Uses/python.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Mk/Uses/python.mk Tue Dec 12 12:16:37 2017 (r456123) > +++ head/Mk/Uses/python.mk Tue Dec 12 12:31:10 2017 (r456124) > @@ -566,6 +566,9 @@ RUN_DEPENDS+=3D cython-${PYTHON_VER}:lang/cytho= n@ > ${PY_FL > .endif > > .if defined(_PYTHON_FEATURE_CONCURRENT) > +.if !defined(_PYTHON_FEATURE_FLAVORS) && (${_PYTHON_VERSION_MINIMUM:M3*} > || ${_PYTHON_VERSION_MAXIMUM:M2*}) > +DEV_WARNING+=3D "USE_PYTHON=3Dconcurrent when only one of Python 2 or 3= is > supported AND not using flavors does not make any sense" > +.endif > _USES_POST+=3D uniquefiles:dirs > .if defined(_PYTHON_FEATURE_FLAVORS) && ${FLAVOR} =3D=3D ${FLAVORS:[1]} > UNIQUE_DEFAULT_LINKS=3D yes Hi Mat, I=E2=80=99m not sure I fully understand this warning, so perhaps it needs a= few more words about =E2=80=9Cwhy=E2=80=9D? Even with flavors, it is still likely people will want 2 flavors of a port concurrently installed. Does adding flavors already handle concurrent installation, making the concurrent keyword unnecessary with flavors enabled? Thanks in advance. Regards, Ben > -- -- From: Benjamin Woods woodsb02@gmail.com