From nobody Mon Nov 1 19:37:40 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2FD0F18422C4; Mon, 1 Nov 2021 19:53:48 +0000 (UTC) (envelope-from otis@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HjkHb6Kn9z3vTk; Mon, 1 Nov 2021 19:53:47 +0000 (UTC) (envelope-from otis@FreeBSD.org) Received: from ns2.wilbury.net (ns2.wilbury.net [IPv6:2a01:b200:0:1:f816:3eff:fecd:13e6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "svc.wilbury.net", Issuer "R3" (verified OK)) (Authenticated sender: otis) by smtp.freebsd.org (Postfix) with ESMTPSA id 86D6A2A9A8; Mon, 1 Nov 2021 19:53:47 +0000 (UTC) (envelope-from otis@FreeBSD.org) Received: from smtpclient.apple (gw-upc.owhome.net [188.167.168.254]) (Authenticated sender: juraj@lutter.sk) by svc.wilbury.net (Postfix) with ESMTPSA id 59A4845CF70; Mon, 1 Nov 2021 20:37:42 +0100 (CET) From: Juraj Lutter Message-Id: <85E45344-2BEE-48D0-A460-F62CD1B152CA@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: d356121270d7 - main - mail/postfix{,-ldap-sasl,-sasl}: Flavorize Date: Mon, 1 Nov 2021 20:37:40 +0100 In-Reply-To: Cc: Yasuhiro Kimura , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org To: Tobias Kortkamp References: <202110280007.19S07MMW076891@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14 Content-Type: multipart/alternative; boundary="Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3" --Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, > On 1 Nov 2021, at 19:44, Tobias Kortkamp wrote: >=20 > On Thu, Oct 28, 2021 at 12:07:22AM +0000, Yasuhiro Kimura wrote: >> -POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" \ >> - -DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" \ >> - -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" \ >> - -DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" \ >> - = -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" \ >> - = -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" \ >> - -DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" \ >> - -DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" \ >> - -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" \ >> - -DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" \ >> - -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" \ >> - -DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" \ >> - -DDEF_MAIL_OWNER=3D\\\"postfix\\\" \ >> - -DDEF_SGID_GROUP=3D\\\"maildrop\\\" \ >> - -Wmissing-prototypes -Wformat -Wno-comment >> +POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" = -DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" = -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" = -DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" = -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" = -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" = -DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" = -DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" = -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" = -DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" = -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" = -DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" = -DDEF_MAIL_OWNER=3D\\\"postfix\\\" -DDEF_SGID_GROUP=3D\\\"maildrop\\\" = -Wmissing-prototypes -Wformat -Wno-comment >=20 > Hi, >=20 > this is caused by a tokenizer bug in portfmt where it treated > the entire thing as one word. It is not ok for portfmt to format > POSTFIX_CCARGS like that. I fixed it in [0]. >=20 > Sorry, I saw it in the review earlier but forgot to comment on > it. Please report stuff like this to me on GitHub [1] or on > Bugzilla. >=20 I will commit a better readable Makefile without any functional changes. Thanks anyway for portfmt update :-) otis =E2=80=94 Juraj Lutter otis@FreeBSD.org --Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3-- --Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQR9WLqI3W4V0bRHtaAtyIKFszIZVAUCYYBCBAAKCRAtyIKFszIZ VHy7AP0dVzjWS45GlUt2PP1M8k9Y/tExpDkCDGYRKOVMihZsVAEAnJZM2+m13oq8 lc1DOsNKWc8F/XmY1e8u5nRdwgBoLqI= =+/pG -----END PGP SIGNATURE----- --Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14--