From owner-cvs-all Wed Oct 23 11: 0:27 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EEAB037B41E; Wed, 23 Oct 2002 11:00:25 -0700 (PDT) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E9F843E42; Wed, 23 Oct 2002 11:00:25 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.12.6/8.12.5) with ESMTP id g9NI0O4G051396; Wed, 23 Oct 2002 11:00:25 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.12.6/8.12.6/Submit) id g9NI0OnW051395; Wed, 23 Oct 2002 11:00:24 -0700 (PDT) Date: Wed, 23 Oct 2002 11:00:24 -0700 From: Steve Kargl To: Bruce Evans Cc: Mark Murray , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include stdlib.h src/lib/libc/gen getbsize.3 getbsize.c Message-ID: <20021023180024.GA38880@troutmask.apl.washington.edu> References: <200210231418.g9NEI7Ob002138@repoman.freebsd.org> <20021024035920.R23637-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021024035920.R23637-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Oct 24, 2002 at 04:00:32AM +1000, Bruce Evans wrote: > On Wed, 23 Oct 2002, Mark Murray wrote: > > > markm 2002/10/23 07:18:07 PDT > > > > Modified files: > > include stdlib.h > > lib/libc/gen getbsize.3 getbsize.c > > Log: > > Make the first argument of getbsize a size_t* instead of an int*, as this is > > what the quantity actually is. Fix an easy const while I'm here. > > This breaks binary compatibility on 64-bit machines. > It also breaks world. cc -O -pipe -mcpu=pentiumpro -c /usr/src/usr.bin/systat/swap.c /usr/src/usr.bin/systat/swap.c:61: conflicting types for `getbsize' /usr/obj/usr/src/i386/usr/include/stdlib.h:230: previous declaration of `getbsize' *** Error code 1 -- Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message