From owner-freebsd-current@FreeBSD.ORG  Sat Apr 14 16:31:49 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3041316A402
	for <current@freebsd.org>; Sat, 14 Apr 2007 16:31:49 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id E3B2B13C45B
	for <current@freebsd.org>; Sat, 14 Apr 2007 16:31:48 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id E66998BD0E0;
	Sat, 14 Apr 2007 18:31:47 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id q3McO89nyZQc; Sat, 14 Apr 2007 18:31:46 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id B8D6066C9AE;
	Sat, 14 Apr 2007 18:31:46 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l3EGVkJW083474;
	Sat, 14 Apr 2007 18:31:46 +0200 (CEST) (envelope-from rdivacky)
Date: Sat, 14 Apr 2007 18:31:46 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Maxim Konovalov <maxim@macomnet.ru>
Message-ID: <20070414163146.GA83428@freebsd.org>
References: <20070414154242.GA82355@freebsd.org>
	<20070414200928.F9990@mp2.macomnet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070414200928.F9990@mp2.macomnet.net>
User-Agent: Mutt/1.4.2.2i
Cc: current@freebsd.org
Subject: Re: off-by-one error in sbin/atm
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2007 16:31:49 -0000

On Sat, Apr 14, 2007 at 08:09:40PM +0400, Maxim Konovalov wrote:
> On Sat, 14 Apr 2007, 17:42+0200, Roman Divacky wrote:
> 
> > hi
> >
> > in /usr/src/sbin/atm/atmconfig/diag.c on line 871 there's
> > off-by-one error. array of size IFNAMSIZ is being written
> > on IFNAMSIZ, ie. one byte after the array.
> >
> > this code
> >         ifr.ifr_name[IFNAMSIZ] = '\0';
> > should be
> >         ifr.ifr_name[IFNAMSIZ-1] = '\0';
> >
> > thnx for fixing it :)
> 
> fixed, thanks.

thnx, that was fast :) just a note.. this was found by compiling
world using gcc43. I wonder how many more I'll find :)