From owner-svn-ports-all@freebsd.org  Tue Mar  8 08:10:10 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF540AC3CAB;
 Tue,  8 Mar 2016 08:10:10 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id D5081F03;
 Tue,  8 Mar 2016 08:10:10 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D45C9146F; Tue,  8 Mar 2016 08:10:10 +0000 (UTC)
Date: Tue, 8 Mar 2016 08:10:10 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: wenheping <wenheping2000@hotmail.com>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r410453 - in head/math/fityk: . files
Message-ID: <20160308081010.GA21062@FreeBSD.org>
References: <201603061053.u26Arwc9042914@repo.freebsd.org>
 <20160307103754.GA45158@FreeBSD.org>
 <BLU168-W38C545AE14EE4DC0FF7394ACB20@phx.gbl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BLU168-W38C545AE14EE4DC0FF7394ACB20@phx.gbl>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 08:10:11 -0000

On Tue, Mar 08, 2016 at 09:22:54AM +0800, wenheping wrote:
> In the whole portstree, there are many mute installations such as "@cd
> ${WRKSRC} && ${COPYTREE_SHARE}",

These are wrong.  Unfortunately, there're lots of bugs in the Makefiles
throughout the Ports Tree.

> and there are many 'not mute' installations such as "cd ${WRKSRC} &&
> ${COPYTREE_SHARE}" too.

These are correct.

> I did not find 'not mute installation" is wrong in Porter's Handbook.

It might not be articulated loud enough, but it's pretty obvious once you
think about it: muted commands won't appear in the build log, which makes
it harder to debug and fix any issues.

mkdir's are often muted because they do not have the same "debug value" as
installation commands, but all cp/COPYTREE_SHARE/ln/etc. commands should
not be muted.  This is pretty common knowledge in our community, I find it
strange that you've never heard of it.

./danfe