From owner-dev-commits-src-main@freebsd.org Mon Mar 1 17:24:55 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF6BC5658C1 for ; Mon, 1 Mar 2021 17:24:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dq6Zv5K0Rz3Fwq for ; Mon, 1 Mar 2021 17:24:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x831.google.com with SMTP id 18so9947353qty.3 for ; Mon, 01 Mar 2021 09:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vB8sWkJ6mWtwfb+ywf/YDRbHtUOAArg1rmqQRWL2qjc=; b=rsqppuwpuVyp/yvvmbiNTujaxPCOrGIXkSzBfZPpJUDFSoq3tQZQ8tCBKiGuQH6Kfw r3G/bec6bNJrYsYvQ6QKAqSwdey6on6Ksijj45UfwGmkiGT/a2EZjTb6C9vQhQCYkgr+ Wg6U3nqSK/D5ZKkd8STDWwE5w5od9TUC23KJ0py4kwWpqgZSE58lYIoyttLlamNZh0hv +UDadOKwE6fFlySpsRkwXnOvF7ZhLa7xRmZlXL+nek0t0n/T8i/p5fZgENMrrZOeklTp i1egkeF2i1swLINigAAHxMOu76mHNp9/tdqu14bCTKCRTg6Qx04noAO/k7ZNQXo9xzsq EDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vB8sWkJ6mWtwfb+ywf/YDRbHtUOAArg1rmqQRWL2qjc=; b=dlQj0+EnMljTkgD804WyyWQSYesCbSM7vS79ePR/6glK+jHVHl+je9eJFVH1pkAyA8 jdexhP0qS2Dtosb4ISGO/BF4BHJuffHG7tMhOXoioelZYvyHFUrVd05MPqEPRef6sQU8 lZHdkjXd75LoywLISmzPK0P5GvyOISA81qc/sgODqy/QZT8MdhOeNxzR9/L8VAe0hAyh bIJ3lji9p+ZpY4PwEyqd/hSSoaWIAe4CBb5aOItj1awmu0wn3GJgyuZFPYMeUx8Y7jv5 z489NE2BmRQ1qtHIGra4qZzAVsUCx7Kcck0og6q/hSaQWNypuczcM8sUvXPJB8WTmkjm tw4w== X-Gm-Message-State: AOAM531VW8C/XLtL949CXv0ziM8TxkCuU6iuO5ew2lV3N4AnmoTp1M4x DZh8GHu2804XxI6UbjPF5h+Z9bDtNEXmVV/BlVW6fQ== X-Google-Smtp-Source: ABdhPJy9y7wtaDh559vd7SHBARfgzijpD1GxMnNJJPXf9H3IKB3UDLxUtoh+/WYrxlLP2hdczh+jAqHEsmL9/hXyr78= X-Received: by 2002:a05:622a:1c9:: with SMTP id t9mr14440370qtw.244.1614619494757; Mon, 01 Mar 2021 09:24:54 -0800 (PST) MIME-Version: 1.0 References: <202102232124.11NLOT27012354@gitrepo.freebsd.org> <583f83d8-c78b-d961-d2c5-9693bd36563b@freebsd.org> <743fd126-2077-49b1-9c85-7ccc61616b98@www.fastmail.com> <460ceb98-e0c1-42b3-8e3c-2587c5ce8398@www.fastmail.com> <8215cd95-6905-49da-ab07-65796845613c@www.fastmail.com> <82f307a1-d7e2-0950-510d-148a1a7e61a2@freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 1 Mar 2021 10:24:43 -0700 Message-ID: Subject: Re: git: 0b7472b3d8d2 - main - Mount the EFI system partition (ESP) on newly-installed systems. To: Kyle Evans Cc: Nathan Whitehorn , Brandon Bergren , Kevin Bowling , Jessica Clarke , Colin Percival , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4Dq6Zv5K0Rz3Fwq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 17:24:55 -0000 On Mon, Mar 1, 2021 at 9:50 AM Kyle Evans wrote: > On Mon, Mar 1, 2021 at 10:45 AM Nathan Whitehorn > wrote: > > > > > > > > On 3/1/21 11:42 AM, Kyle Evans wrote: > > > On Mon, Mar 1, 2021 at 10:39 AM Nathan Whitehorn < > nwhitehorn@freebsd.org> wrote: > > >> > > >> > > >> On 2/28/21 3:44 PM, Brandon Bergren wrote: > > >>> On Sun, Feb 28, 2021, at 2:25 PM, Warner Losh wrote: > > >>>> Yes. I agree as well. I was just hoping to say just that: EFI is > barely > > >>>> theoretically possible, but in reality we'll likely never use it.... > > >>>> > > >>>> The net effect is that we don't want to install efi on powerpc on > freebsd. > > >>>> > > >>>> Warner > > >>>> > > >>> Yeah. The code before the change excluded mips and powerpc > platforms, and it should continue to do so instead of using the existence > of a /boot/efi directory as the only clue. > > >>> > > >>> Currently bsdinstall bails out and leaves powerpc* in a > half-installed state because the die in the uname case propagates to the > main script, so it never runs the bits after the bootconfig. > > >>> > > >> So that was a deliberate choice to keep the list of places that know > > >> about efi vs. non-EFI centralized. I'd prefer to just not make that > > >> directory on systems where it doesn't apply rather than messing with > the > > >> installer. Do you know where it is being made? > > >> -Nathan > > > It's part of the hierarchy in ^/etc/mtree/BSD.root.dist > > > > > > > Is there a reason it needs to be? The installer bits all make it when > > needed already, so just removing it there seems like the simplest path. > > I can't think of a reason, as long as both the release(7) scripts and > the installer create it as needed -- I note that vmimage.subr seems to > create it itself, but arm.subr seems to get it wrong atm. It'll need > to create /boot/efi for PART_SCHEME == GPT, and /boot/msdos should > probably be scoped down to PART_SCHEME == MBR where it's used at the > moment. > I think that it should be /boot/efi for both, with a symlink from /boot/msdos to /boot/efi so we can migrate away from that old scheme... Warner