From owner-svn-src-all@FreeBSD.ORG Thu Jan 14 09:30:53 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57F62106566C; Thu, 14 Jan 2010 09:30:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id D47D78FC0A; Thu, 14 Jan 2010 09:30:52 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o0E9UiIe076125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jan 2010 11:30:44 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o0E9UiRu093535; Thu, 14 Jan 2010 11:30:44 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o0E9UiwF093534; Thu, 14 Jan 2010 11:30:44 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 14 Jan 2010 11:30:44 +0200 From: Kostik Belousov To: Ed Schouten Message-ID: <20100114093044.GW62907@deviant.kiev.zoral.com.ua> References: <201001140535.o0E5ZWCx038013@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E75mJrUy8lRi9cGN" Content-Disposition: inline In-Reply-To: <201001140535.o0E5ZWCx038013@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r202274 - in head: . include lib/libc/gen libexec/getty X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2010 09:30:53 -0000 --E75mJrUy8lRi9cGN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 14, 2010 at 05:35:32AM +0000, Ed Schouten wrote: > Author: ed > Date: Thu Jan 14 05:35:32 2010 > New Revision: 202274 > URL: http://svn.freebsd.org/changeset/base/202274 >=20 > Log: > Phase out ttyslot(3). > =20 > The ttyslot() function was originally part for SUSv1, marked LEGACY in > SUSv2 and removed later on. This function only makes sense when using > utmp(5), because it was used to determine the offset of the record for > the controlling TTY. It makes little sense to keep it here, because the > new utmpx file format doesn't index based on TTY slots. >=20 > Modified: > head/ObsoleteFiles.inc > head/include/unistd.h > head/lib/libc/gen/Symbol.map > head/lib/libc/gen/ttyname.3 > head/lib/libc/gen/ttyslot.c > head/libexec/getty/ttys.5 >=20 > Modified: head/ObsoleteFiles.inc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/ObsoleteFiles.inc Thu Jan 14 02:48:39 2010 (r202273) > +++ head/ObsoleteFiles.inc Thu Jan 14 05:35:32 2010 (r202274) > @@ -14,6 +14,8 @@ > # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS l= ast. > # > =20 > +# 20100114: removal of ttyslot(3) > +OLD_FILES+=3Dusr/share/man/man3/ttyslot.3.gz > # 20100113: remove utmp.h, replace it by utmpx.h > OLD_FILES+=3Dusr/share/man/man3/login.3.gz > OLD_FILES+=3Dusr/share/man/man3/logout.3.gz >=20 > Modified: head/include/unistd.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/include/unistd.h Thu Jan 14 02:48:39 2010 (r202273) > +++ head/include/unistd.h Thu Jan 14 05:35:32 2010 (r202274) > @@ -574,7 +574,6 @@ int swapon(const char *); > int swapoff(const char *); > int syscall(int, ...); > off_t __syscall(quad_t, ...); > -int ttyslot(void); > int undelete(const char *); > int unwhiteout(const char *); > void *valloc(size_t); /* obsoleted by malloc() */ >=20 > Modified: head/lib/libc/gen/Symbol.map > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libc/gen/Symbol.map Thu Jan 14 02:48:39 2010 (r202273) > +++ head/lib/libc/gen/Symbol.map Thu Jan 14 05:35:32 2010 (r202274) > @@ -272,7 +272,6 @@ FBSD_1.0 { > openlog; > closelog; > setlogmask; > - ttyslot; > ttyname_r; > ttyname; > timezone; You should never remove symbol from the version map for shared library. Doing that removes one of the reason for having symbol versioning at all (namely, pre-execution check that version requirements of the objects are satisfied). FreeBSD allows version maps to grow, that makes the check weaker then it ought to be. --E75mJrUy8lRi9cGN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAktO5EQACgkQC3+MBN1Mb4hs5QCgzfDRqSb/+IWbD9dx2fsGmIuv 6SwAn2AV12ANI/URRiMhxlrE5XO1cfqh =1qS3 -----END PGP SIGNATURE----- --E75mJrUy8lRi9cGN--