From owner-freebsd-bugs  Sat Dec 16 15:52:33 1995
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id PAA11499
          for bugs-outgoing; Sat, 16 Dec 1995 15:52:33 -0800 (PST)
Received: from ucvg.med.utah.edu (ucvg.med.utah.edu [128.110.62.18])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id PAA11491
          for <freebsd-bugs@freefall.freebsd.org>; Sat, 16 Dec 1995 15:52:28 -0800 (PST)
Received: (from rick@localhost) by ucvg.med.utah.edu (8.6.11/8.6.11) id QAA11082; Sat, 16 Dec 1995 16:55:05 -0700
Resent-Date: Sat, 16 Dec 1995 13:40:08 -0800 (PST)
Resent-Message-Id: <199512162140.NAA02834@freefall.freebsd.org>
Resent-From: gnats@freefall.freebsd.org (GNATS Management)
Resent-To: freebsd-bugs@freefall.freebsd.org
Resent-Reply-To: FreeBSD-gnats@freefall.freebsd.org, jc@irbs.com
Message-Id: <199512162138.QAA00570@irbs.irbs.com>
Date: Sat, 16 Dec 1995 16:38:49 -0500
From: John Capo <jc@irbs.com>
Reply-To: jc@irbs.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/895: ppp predictor-1 memory leak [PATCH included]
ReSent-Date: Sat, 16 Dec 1995 16:55:00 -0700 (MST)
ReSent-From: Rick Scheese <rick@ucvg.med.utah.edu>
ReSent-To: rick@rscheese.med.utah.edu
ReSent-Message-ID: <Pine.ULT.3.91.951216165500.10978D@ucvg.med.utah.edu>
Sender: owner-bugs@freebsd.org
Precedence: bulk


>Number:         895
>Category:       bin
>Synopsis:       ppp predictor-1 memory leak [PATCH included]
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 16 13:40:02 PST 1995
>Last-Modified:
>Originator:     John Capo
>Organization:
IRBS Engineering
>Release:        FreeBSD 2.1-STABLE i386
>Environment:

	

>Description:

A link problem, like a silo overflow, that will cause a FCS error
results in a memory leak for each input packet and FCS failures on
all subsequent predictor-1 compressed input packets.


>How-To-Repeat:

Enable and allow predictor-1 compression
Run something that will generate considerable input to ppp
Cause a silo overflow, start Xinside for instance

>Fix:
	

*** pred.c.orig	Mon May 29 23:50:55 1995
--- pred.c	Sat Dec 16 16:27:20 1995
***************
*** 182,187 ****
--- 182,188 ----
      if (len != len1) {	/* Error is detected. Send reset request */
        CcpSendResetReq(&CcpFsm);
        pfree(bp);
+       pfree(wp);
        return;
      }
      cp += olen - 4;
***************
*** 213,218 ****
--- 214,224 ----
        proto = (proto << 8) | *pp++;
      }
      DecodePacket(proto, wp);
+   }
+   else
+   {
+     CcpSendResetReq(&CcpFsm);
+     pfree(wp);
    }
    pfree(bp);
  }
>Audit-Trail:
>Unformatted: