From owner-svn-src-head@FreeBSD.ORG Tue Dec 1 06:09:49 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id E40C41065694 for ; Tue, 1 Dec 2009 06:09:49 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from xps.daemonology.net (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx2.freebsd.org (Postfix) with SMTP id 41EF014E10D for ; Tue, 1 Dec 2009 06:09:49 +0000 (UTC) Received: (qmail 82538 invoked from network); 1 Dec 2009 06:09:48 -0000 Received: from unknown (HELO xps.daemonology.net) (127.0.0.1) by localhost with SMTP; 1 Dec 2009 06:09:48 -0000 Message-ID: <4B14B32C.3060409@freebsd.org> Date: Mon, 30 Nov 2009 22:09:48 -0800 From: Colin Percival User-Agent: Thunderbird 2.0.0.23 (X11/20090919) MIME-Version: 1.0 To: Brian Feldman References: <200912010504.nB154VnS053167@svn.freebsd.org> In-Reply-To: <200912010504.nB154VnS053167@svn.freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r199983 - in head: lib/libc/stdlib tools/regression/environ X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2009 06:09:50 -0000 Brian Feldman wrote: > Do not gratuitously fail *env(3) operations due to corrupt ('='-less) > **environ entries. This puts non-getenv(3) operations in line with > getenv(3) in that bad environ entries do not cause all operations to > fail. There is still some inconsistency in that getenv(3) in the > absence of any environment-modifying operation does not emit corrupt > environ entry warnings. > > I also fixed another inconsistency in getenv(3) where updating the > global environ pointer would not be reflected in the return values. > It would have taken an intermediary setenv(3)/putenv(3)/unsetenv(3) > in order to see the change. The FreeBSD Security Team is currently dealing with a security issue relating to this code. Please back out your change (at least to getenv.c; I don't particularly care about the regression tests) until we've finished, and then submit the patch to us for review along with a detailed explanation of what it does. We've already had two major security issues arising out of getenv.c in the past year, and I'd like to make sure we don't have a third. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid