From owner-freebsd-current  Mon Aug 12 10:10:30 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1674D37B400
	for <freebsd-current@FreeBSD.ORG>; Mon, 12 Aug 2002 10:10:28 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 15A6143E75
	for <freebsd-current@FreeBSD.ORG>; Mon, 12 Aug 2002 10:10:27 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id DAA26680;
	Tue, 13 Aug 2002 03:10:00 +1000
Date: Tue, 13 Aug 2002 03:15:02 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: Terry Lambert <tlambert2@mindspring.com>,
	David Xu <bsddiy@yahoo.com>, Julian Elischer <julian@elischer.org>,
	FreeBSD CURRENT <freebsd-current@FreeBSD.ORG>
Subject: Re: cvs commit: src/sys/kern kern_sig.c (fwd)
In-Reply-To: <20020812113101.GA2089@nagual.pp.ru>
Message-ID: <20020813031235.O25510-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Mon, 12 Aug 2002, Andrey A. Chernov wrote:

> On Mon, Aug 12, 2002 at 04:03:31 -0700, Terry Lambert wrote:
> > "Andrey A. Chernov" wrote:
> > > On Sun, Aug 11, 2002 at 22:53:15 -0700, David Xu wrote:
> > > > following is patch for su, I can type "suspend" and stop $$ without the
> > > > problem you described, I have tested it under tcsh and bash, all works
> > > > for me.
> > >
> > > Thanx, committed.
> >
> > UGH!
> >
> > #1	License on patch is GPL
>
> Why not Microsoft?
>
> > #2	I guess now that this irritant is gone, the signals code
> > 	will remain screwed up, until some time later when you
> > 	see the shark fin above water, just before it bites
> > 	someone else?
>
> Read commit message 2 or 3 times. Meditate on each word.

Anyway, it has one blatant style bug (not 1TBS) and no explanation of
the bug, so it should not have been committed verbatim.  See another
reply for an analysis of the patch.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message