From owner-freebsd-fs@FreeBSD.ORG Thu May 13 14:00:13 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B1AD106566C for ; Thu, 13 May 2010 14:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E51B78FC18 for ; Thu, 13 May 2010 14:00:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4DE0C7J067983 for ; Thu, 13 May 2010 14:00:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4DE0Cw0067982; Thu, 13 May 2010 14:00:12 GMT (envelope-from gnats) Date: Thu, 13 May 2010 14:00:12 GMT Message-Id: <201005131400.o4DE0Cw0067982@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Robert Noland Cc: Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Robert Noland List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2010 14:00:13 -0000 The following reply was made to PR bin/144214; it has been noted by GNATS. From: Robert Noland To: Andriy Gapon Cc: bug-followup@FreeBSD.org, c.kworr@gmail.com Subject: Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14 Date: Thu, 13 May 2010 08:52:14 -0500 Andriy Gapon wrote: > It seems that I have been misunderstanding the problem. > "ZFS: gang block detected" won't even appear if boot code is too old. > > Having briefly glanced over the code and comparing it to the code in osol and in > zio_gang_tree_issue(), I think the following change is needed. > But I am not sure if it is a real fix for the issue at hand. > > If anyone can reproduce the problem, could you please test this change? > Thanks! This looks sane. I was never actually able to test it, since reproducing the issue is rather tricky. robert. >