From nobody Tue Feb 24 03:17:45 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKjb266pbz6SrrX for ; Tue, 24 Feb 2026 03:17:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKjb25QJVz3DSf for ; Tue, 24 Feb 2026 03:17:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771903070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oRQ8m+kJHseunfjQ8n8qeNOynpo+kPXOa3W1g0+fd8k=; b=QnHBpUeYOOWnFntVw8aIBhzb0XMm5UAzeQiBhg9T8/u8IdjwzXO+ZpMvQLBx4A3iC0ePFd B8QCWYqY3ANvALORchJT+COOb31mvUCvxebKHEtmons0OaIkrAlXuQYl0HmrRg4U4LQDPv NtT6rSj+MYEl9dkCct/V5wBe/2KUInPoHpsfYltSIwmd5zRcx7oku8iv5yaY9TiXT4KVyF sRCp/7bv0tpCtg4raP4O1W3MmRsXq6a7fIuFS0x6ZBRAHDFxOmxQpWVcznDMyBSjL1xI5s RkEdJ7pnzQSrsrgNgAhBD39t8FbZZQRw6cx5+v4OEIAwlxCnUMOfDat80yetkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771903070; a=rsa-sha256; cv=none; b=Rf6qAJpJ+fsHhBM/CFVqsPwC44OAJYFsZ9K2cRqK9g/L8ZqLdBLEqlemBk/FMFKQfnZpJR gDuV2stjryfLD9aXDmONuXBoeW1f5yDF6+kPhw4Ep2jwm/VctH/zWp/tgJeBi3/JiPijjH FozfxW7TbiHnfPtbBi81xEdsx08tdu11FVjImqKx3ff8EzlsfTxJy+deqSgJ2e+OM38cUZ +4S8UKgQL3G9WuG4tRu671Dve+XPPGRwf14Ky1POZgrBO5Wf+3Dro1nTFXWU7zaxFLTOFv TI8ZR8swT+XqC6KZKtx225VYTfgS1FjcC8ln6FtuhKOvOkFzHny7CECViEkx3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771903070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oRQ8m+kJHseunfjQ8n8qeNOynpo+kPXOa3W1g0+fd8k=; b=X6tXJGHY+Bx3DttjJUZK8lvcTw8ipUmokOu4nYkWed9+p70QFHGgB+Z9VPNkMVoMBAkurj R6heX7DZjcSF4JPXuWyVemqhigI5A0hlj9OiPh6zoOgJPWoZCr7Y+JEh9qJ7Nr0eJ+9ptS VPfrqYvqUXMmU57Bx348B0IJjNkXERjbuQ9AvGSiEeb9DEmYHMoAUpHA+9NO5bawS8mEfW 3IDmHL7wYo3nGeTIY+7jKJTk91lMjNLj3cVdXeE71bFt2YDfagugEPmwDF6yxAVOPkakHF 0YgcdsnLlUDKg++T3KeeelfmJihWUMOCbxtFKsZvTlJWxNVQaWpZ+nwHXo2mBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fKjb24kbDzxq4 for ; Tue, 24 Feb 2026 03:17:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 271bd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 03:17:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: John Baldwin From: Cy Schubert Subject: git: 51bb8e49cf7e - stable/14 - heimdal: Pass the correct pointer to free in an error case List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 51bb8e49cf7e0d6e42cbae980c3b57d8a71af07b Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 03:17:45 +0000 Message-Id: <699d1859.271bd.2e28eee7@gitrepo.freebsd.org> The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=51bb8e49cf7e0d6e42cbae980c3b57d8a71af07b commit 51bb8e49cf7e0d6e42cbae980c3b57d8a71af07b Author: John Baldwin AuthorDate: 2026-01-31 17:00:44 +0000 Commit: Cy Schubert CommitDate: 2026-02-24 03:17:34 +0000 heimdal: Pass the correct pointer to free in an error case This fixes a warning reported by GCC 14 on stable/14: crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] 241 | free(hist_keys); | ^~~~~~~~~~~~~~~ crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc' 234 | ext = calloc(1, sizeof (*ext)); | ^~~~~~~~~~~~~~~~~~~~~~~~ Reviewed by: rmacklem, cy Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54932 (cherry picked from commit b26a7af438f36dcde86f39a681123cc2140affb2) --- crypto/heimdal/lib/hdb/keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/hdb/keys.c b/crypto/heimdal/lib/hdb/keys.c index 9c0af5c47f23..ef6113610009 100644 --- a/crypto/heimdal/lib/hdb/keys.c +++ b/crypto/heimdal/lib/hdb/keys.c @@ -238,7 +238,7 @@ hdb_add_current_keys_to_history(krb5_context context, hdb_entry *entry) hist_keys = &ext->data.u.hist_keys; hist_keys->val = calloc(1, sizeof (*hist_keys->val)); if (hist_keys->val == NULL) { - free(hist_keys); + free(ext); return ENOMEM; } hist_keys->len = 1;