From owner-freebsd-ports@FreeBSD.ORG  Tue Apr  3 16:16:09 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6E4821065677;
	Tue,  3 Apr 2012 16:16:09 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id C1DEA8FC1F;
	Tue,  3 Apr 2012 16:16:08 +0000 (UTC)
Received: by bkcjc3 with SMTP id jc3so4465235bkc.13
	for <multiple recipients>; Tue, 03 Apr 2012 09:16:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=4Mfo8mJi4xxYfjWMsz6aFjUNtjpSltlzFE2DIvi6+Hw=;
	b=vEYkd/aTsIN8AE5HC9d2LYoY7ZBuWyYTp5pBOVETJHmfNZnPZhKWWnbla8kukpAwF7
	6wNcD5VKEm2n2MrkaCamTZrRtEkyC79nd+WXOxTH0dlsD1pI5fAt0y2qvs6D/fquOYvj
	ltPjOufL4pDzecALKAm6FywNwajCiSNLpIBIevPn4JYwulYNnFz3w4LF+fOKDREErMh6
	Fj4xvxz7LkK4JtfNafJh7zgJ58BVd7fd6PNc3E9YY14JAXt+eAlCN5+Do1Sz5nJ+Vcmo
	n5zS48L+LhInaa2KhLRWMtFZ39H7a4w0e9IKckBXnMCl+aK5YGEaOHCTaDFthdwiD9ze
	BsrA==
Received: by 10.204.150.86 with SMTP id x22mr5864604bkv.136.1333469767823;
	Tue, 03 Apr 2012 09:16:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.202.142 with HTTP; Tue, 3 Apr 2012 09:15:37 -0700 (PDT)
In-Reply-To: <4F74152F.4090302@FreeBSD.org>
References: <CADLo839cUtxHJNqYQtvaFSp9Jjg21Hsn0U7xiOS9JuGmkhETmg@mail.gmail.com>
	<4F74152F.4090302@FreeBSD.org>
From: Chris Rees <utisoft@gmail.com>
Date: Tue, 3 Apr 2012 16:15:37 +0000
Message-ID: <CADLo83898nJ8fvtyapJ9Qtsbm5-dWVw1hLMXkNEUSc2Rv5rM+Q@mail.gmail.com>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: ports@freebsd.org
Subject: Re: How useful is %%DATADIR%%, anyway?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 16:16:09 -0000

On 29 March 2012 07:54, Doug Barton <dougb@freebsd.org> wrote:
> On 3/23/2012 1:14 PM, Chris Rees wrote:
>> Just as a thought, I decided to try stripping out all mentions of
>> %%DATADIR%%, %%DOCSDIR%% etc from pkg-plist, and replacing them with
>> PORTDOCS=3D*, PORTDATA=3D* in the Makefiles etc.
>
> How much time does creating the dynamic plists take for ports with
> larger numbers of docs/data, vs. the static lists; and how many ports
> would be adversely affected, if any?

Well... running find on a directory tree doesn't take very long if all
we're doing is grabbing filenames, vs a 7% speedup of a ports csup (a
gross estimate of course, and portsnap compression will probably at
least partially eliminate this!).  Worth remembering that the find is
only done on ports that are installed, rather than csup which is done
on *every* port.

> In regards to the idea itself, I like dynamic (or more dynamic) plist
> generation whenever possible, so I think you're going the right direction=
.
>
> One small note, some of us use a construction like this:
>
> PORTDOCS=3D =A0 =A0 =A0 foo bar baz
>
> post-install:
> .for file in ${PORTDOCS}
> =A0 =A0 =A0 =A0...
> .endfor
>
> So taking into consideration that '*' might not always be literally '*',
> I'm in favor.

Great!  I'll get docs patches in soon.

Chris