From owner-svn-src-head@FreeBSD.ORG Fri Jun 14 03:31:11 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8A71E7A9; Fri, 14 Jun 2013 03:31:11 +0000 (UTC) (envelope-from gibbs@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 7CF701C41; Fri, 14 Jun 2013 03:31:11 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r5E3VBAf039559; Fri, 14 Jun 2013 03:31:11 GMT (envelope-from gibbs@svn.freebsd.org) Received: (from gibbs@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r5E3VBAO039558; Fri, 14 Jun 2013 03:31:11 GMT (envelope-from gibbs@svn.freebsd.org) Message-Id: <201306140331.r5E3VBAO039558@svn.freebsd.org> From: "Justin T. Gibbs" Date: Fri, 14 Jun 2013 03:31:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r251729 - head/sys/dev/xen/netfront X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jun 2013 03:31:11 -0000 Author: gibbs Date: Fri Jun 14 03:31:11 2013 New Revision: 251729 URL: http://svnweb.freebsd.org/changeset/base/251729 Log: sys/dev/xen/netfront/netfront.c: In netif_free(), call ifmedia_removeall() after ether_ifdetach() so that bpf listeners are detached, any link state processing is completed, and there is no chance for external reference to media information. Suggested by: yongari MFC after: 1 week Modified: head/sys/dev/xen/netfront/netfront.c Modified: head/sys/dev/xen/netfront/netfront.c ============================================================================== --- head/sys/dev/xen/netfront/netfront.c Fri Jun 14 03:28:29 2013 (r251728) +++ head/sys/dev/xen/netfront/netfront.c Fri Jun 14 03:31:11 2013 (r251729) @@ -2178,12 +2178,12 @@ netif_free(struct netfront_info *info) XN_UNLOCK(info); callout_drain(&info->xn_stat_ch); netif_disconnect_backend(info); - ifmedia_removeall(&info->sc_media); if (info->xn_ifp != NULL) { ether_ifdetach(info->xn_ifp); if_free(info->xn_ifp); info->xn_ifp = NULL; } + ifmedia_removeall(&info->sc_media); } static void