From owner-svn-src-head@FreeBSD.ORG Sat Sep 6 22:36:37 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F2C1285; Sat, 6 Sep 2014 22:36:37 +0000 (UTC) Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com [IPv6:2607:f8b0:400d:c04::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF8E21E0E; Sat, 6 Sep 2014 22:36:36 +0000 (UTC) Received: by mail-qg0-f54.google.com with SMTP id q108so6309758qgd.13 for ; Sat, 06 Sep 2014 15:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tLXb0JB2ebmZlrCYy/ufPp1DtuRUWWxgm4ktzULFzPs=; b=XLHi9Pbijad2Yzzr6ksW+OFIJzySgEK6EFXK3/eFvW0aHlcFRvd4cmWyt1wUIlw+wM woH7ipVcVL+WRAlaep0MRALeDPSLrwHwb7aNo01S4ZyT7PVnHTZC3dqUDl0CaZtcgfNV WEZl8sgurKRo97chMDdXL2JKwta2+t8lG3HjWSPIoKzWo5+NuLCF7bqTilljcTCynCl0 D+hANvGXQQtAfUY8A6i9ZlysTOYxzPjM6K0Yx0wDGXSTK9YN4Z5USmIyFPIkBkN5lvej D1pXIqWFy810cD4BlhuPQovHCEbp/qh/6a0tT1PdFEM2q3+fo3k/82e6vHdyBzHynehJ mTbA== MIME-Version: 1.0 X-Received: by 10.224.151.69 with SMTP id b5mr30403076qaw.37.1410042995029; Sat, 06 Sep 2014 15:36:35 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Sat, 6 Sep 2014 15:36:34 -0700 (PDT) In-Reply-To: <540B8457.2020500@rice.edu> References: <53e0a76b.5936.428818a9@svn.freebsd.org> <540B8457.2020500@rice.edu> Date: Sat, 6 Sep 2014 15:36:34 -0700 X-Google-Sender-Auth: 8503W6r2Cub12BLIB2TgtmJ4uDk Message-ID: Subject: Re: svn commit: r269577 - in head/sys: amd64/include arm/arm arm/include conf i386/i386 i386/include kern mips/include mips/mips powerpc/include powerpc/powerpc sparc64/include sparc64/sparc64 sys From: Adrian Chadd To: Alan Cox Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Gleb Smirnoff , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Sep 2014 22:36:37 -0000 On 6 September 2014 15:01, Alan Cox wrote: > On 09/06/2014 16:15, Adrian Chadd wrote: >> Hi Gleb! >> >> This commit has broken mips32 on my 128MB RAM routerstation pro board. >> >> I've tested the commit before this one (and it works). >> >> I've also tested today's -HEAD as there was some subsequent fixes to >> the sfbuf code. It hasn't completely fixed things - I still see >> processes throwing VM errors: > > > Before this commit, the sf_buf code did not cache mappings on MIPS. > Now, it does. So, I suspect that you're experiencing cache consistency > issues. To return to the pre-commit state, you'll need to define > machine-dependent sf_buf_{un,}map() functions in mips/include/sf_buf.h > for mips32 that call pmap_q{remove,enter}, respectively. Look at arm > for a similar configuration. Yup, I just noticed that, fixed it, and updated the bug (bug 193400.) Is this something that should be fixed in the vm/pmap code somewhere, or is this just the correct behaviour? -a