From owner-freebsd-hackers Mon Oct 15 9:13:46 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id E97E837B407 for ; Mon, 15 Oct 2001 09:13:42 -0700 (PDT) Received: (from dillon@localhost) by earth.backplane.com (8.11.6/8.11.2) id f9FGDb854996; Mon, 15 Oct 2001 09:13:37 -0700 (PDT) (envelope-from dillon) Date: Mon, 15 Oct 2001 09:13:37 -0700 (PDT) From: Matt Dillon Message-Id: <200110151613.f9FGDb854996@earth.backplane.com> To: mark tinguely Cc: tmoestl@gmx.net, freebsd-hackers@FreeBSD.ORG, Patrick.Cipiere@udcast.com, tinguely@web.cs.ndsu.nodak.edu Subject: Re: contigfree, free what? References: <200110151610.f9FGAg433017@web.cs.ndsu.nodak.edu> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :I have a potentially silly question about contigmalloc1(), if the very :unlikely occurance that the kernel VM space ran out, (the vm_map_findspace() :failed) wouldn't we want to return the chunk of contiguous physical space :back on the free queue before we return an allocation failure? : :--mark tinguely. Ah, you came across that XXX comment? You are absolutely right. The original implementor rushed writing the routine and didn't finish it. contigmalloc() is only supposed to be used in the early life of the system when its loading device drivers that need contiguous space, so the case is not supposed to come up. Of course, that means that it does come up from time to time :-(. If you want to have a go at fixing it I will be happy to review. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message