From owner-svn-src-all@freebsd.org Tue Feb 26 21:19:05 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE0A2150440A; Tue, 26 Feb 2019 21:19:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 684E573BD2; Tue, 26 Feb 2019 21:19:04 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id yk7xgM5uvgaEyyk7ygMzyt; Tue, 26 Feb 2019 14:19:02 -0700 X-Authority-Analysis: v=2.3 cv=QOMWuTDL c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=enqceGrhu9depbhogb4A:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id B5F78688; Tue, 26 Feb 2019 13:19:00 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1QLIfBt080611; Tue, 26 Feb 2019 13:18:41 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1QLIftV080604; Tue, 26 Feb 2019 13:18:41 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902262118.x1QLIftV080604@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Benjamin Kaduk , Cy Schubert , Baptiste Daroussin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common In-Reply-To: Message from "Rodney W. Grimes" of "Tue, 26 Feb 2019 08:59:46 -0800." <201902261659.x1QGxkl0046685@pdx.rh.CN85.dnsmgr.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 26 Feb 2019 13:18:41 -0800 X-CMAE-Envelope: MS4wfHJfgG7tadoubtBA2XsAAnLngtY5KOnIeSUGedEO0r6FqaZ517UVCZpENk4DgOHbET/SLAwNV9XWou7B+43/Ak5hfaPc3O9y/8fRNGkFKsJ+PsJp4X+s bPZKO4QnZfmeWRK3ke87qgN75AzIDRv1AY71w46SxFzaCzeYIBdZNEHvZGN7wjAvKVYL3/X4huDyYotvA1NmX85CCFUStjNH2laLXVXXX8P7w5S9p9VPc/Iq FWRdPQFrPDFOfz4MncvSnVqiR20eKYOvUIMB3mjFz5ANceWuJOgnDuTXw4d4cepqxtFgb3+YUInsKjXfyYsw+H0kLrgyF+i583bOrQ9++xXM+PWm7urICgy1 3mbsTdq8 X-Rspamd-Queue-Id: 684E573BD2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.82 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; RCPT_COUNT_SEVEN(0.00)[7]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_LOW(-0.10)[13.134.59.64.list.dnswl.org : 127.0.5.1]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.15)[ip: (-5.94), ipnet: 64.59.128.0/20(-2.65), asn: 6327(-2.08), country: CA(-0.09)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 21:19:06 -0000 In message <201902261659.x1QGxkl0046685@pdx.rh.CN85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert > > wrote: > > > > > On February 26, 2019 7:48:27 AM PST, Cy Schubert < > > > Cy.Schubert@cschubert.com> wrote: > > > >On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > > > > wrote: > > > > > > > [trimming the unneeded pile of commit body] > > > > > > > >This broke my systems, many filesystems fail to mount causing nullfs > > > >late mounts to fail. No details now until tonight. > > > > > > > >Suggest we back this out until it is properly tested. > > > > > > Nested zfs filesystems seem not to be handled properly or possibly not > > > supported any more. This explains my mail gateway also not mounting all > > > filesystems in /home. It was odd that dovecot stopped working. > > > > > > The symptom of the problem is zfs mount -a no longer mounts all > > > filesystems. Zfs mount fails saying the filesystem is already mounted. Th > e > > > workaround is to zfs umount each affected zfs dataset by hand and zfs mou > nt > > > it by hand. > > > > > > Generally this has screwed up sites that have hundreds (in my case 122) > > > zfs datasets. The work around might be to script testing each mount, > > > unmounting and remounting if necessary. > > > > > > I'm being sarcastic about creating an rc script to clean this up. This > > > needs to be backed out and tested properly before being committed. > > > > > > > > I don't know what you mean by "nested zfs filesystems" -- do you mean a > > zpool within a zvol? > > That has been unsupported for a long time, IIRC. And > That had better not be unsupported, that is the prefered technology > for all of the virtualization stuff, bhyve, virtualbox, qemu, etc. > > I think by nested zfs it sounds like he is talking about datasets > inside of other datasets just from reading "all filesystems in /home" > > > > I'm not sure what else "nested filesystems" would be, since having (e.g.) > > separate zfs filesystems for /usr and /usr/ports is so common that surely > > it has already been tested... > > It might be when the intervening dataset is marked canmount=off? > Though that should fail for the /usr /usr/foo case, as usr is normally > marked this way. Maybe some other special case. I do have some mountpoint=none datasets with mountpoint=/somewhere-else. My tank/var tree is a good example of the complete mix using none, legacy and specified mountpoints. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.