From owner-svn-src-head@freebsd.org Thu Jan 21 16:55:07 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1A51A8CA6B for ; Thu, 21 Jan 2016 16:55:07 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-yk0-x233.google.com (mail-yk0-x233.google.com [IPv6:2607:f8b0:4002:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F4751DAB for ; Thu, 21 Jan 2016 16:55:07 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-yk0-x233.google.com with SMTP id v14so55163348ykd.3 for ; Thu, 21 Jan 2016 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6e1DZJFncyf9x57zw87XbxzM1f0a/fDoEExIeiIaTkE=; b=wfwIpTNfDrQ9CO0+BBGsHpcZNp7ZoSGzkIHd6quQvDu+j3M4C68qgrr6YRjEz3l2lk Y91b/ZWD25IBquSBeb+RfXrH2FC3cGE6SjtxXPXGvtFc0A6HhfibY64StqMAAKrQ/Fw3 uSDOJOK8x4JYxG0/FmcSO+W4chlGFuTca5ZlAQBimp/Jx561AQ5mZhe7Fd0HDQNWPkzh gI7ymqBrXePJxY1w9NIuJI1YKjmeJHdiSMdhoA7SeNuDGl4LB8sOnFdKbNJYZ01WfJiS hf5p1k+DCGn7DM9tCLiImLslaUdLgy8Gswj9xQUqHwa8oiFym0y2ywOQpU57y62Zf7jn +FHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=6e1DZJFncyf9x57zw87XbxzM1f0a/fDoEExIeiIaTkE=; b=XGeAHjGlZZF6hac9fmh4g7Af9OYw3u9owSNGoSJx7BbDlAL7GzaAEeLoqzWwpbp/ig 25LjuoKK1ncwTCnqxlGDLKVJzWdUDWblMS6e6rhRQx+GswjcZeOIdmG6GF3Tg/cAjNZa 2AB7GliNy2HVdIC/lsTF/p6zOhKmPrJUXmYsyzVA59wF9gXiWIRlr3WL3xE6LCbVC7bF rOwXnUrVHpq776HdAJK8ChBKXgH1Py+wXnEY/C3nfpEAgHDFcHmG2LxV1JG/T4doHDHJ sHp4IYs3Gmgb31blYNdYh+i1R3n3VJvkcJIaWMhExOpagYDY0mDfspN2X/mNCZAZ8LMA RPXA== X-Gm-Message-State: ALoCoQkm0sBKtViwDK2zfu/syNkZgkARBS/95Sd/AWGsPVKqS41erWP0oxS58cTUbGwXTG8m+bWYT+eMyicBAZjEL4jcyO5fCg== X-Received: by 10.37.47.84 with SMTP id v81mr14703104ybv.42.1453395306565; Thu, 21 Jan 2016 08:55:06 -0800 (PST) Received: from mutt-hardenedbsd ([63.88.83.105]) by smtp.gmail.com with ESMTPSA id z201sm1203395ywz.41.2016.01.21.08.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2016 08:55:05 -0800 (PST) Date: Thu, 21 Jan 2016 11:55:01 -0500 From: Shawn Webb To: Hartmut Brandt Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294507 - head/contrib/bsnmp/snmp_mibII Message-ID: <20160121165501.GA88070@mutt-hardenedbsd> References: <201601211611.u0LGBKkV086754@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <201601211611.u0LGBKkV086754@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hardenedbsd 11.0-CURRENT-HBSD FreeBSD 11.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 16:55:07 -0000 --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 21, 2016 at 04:11:20PM +0000, Hartmut Brandt wrote: > Author: harti > Date: Thu Jan 21 16:11:20 2016 > New Revision: 294507 > URL: https://svnweb.freebsd.org/changeset/base/294507 >=20 > Log: > Fill the ifAlias leaf of the ifXTable with the interface description > if there is one available and it fits into the maximum size (64 charact= ers). >=20 > Modified: > head/contrib/bsnmp/snmp_mibII/mibII.c > head/contrib/bsnmp/snmp_mibII/mibII.h > head/contrib/bsnmp/snmp_mibII/mibII_interfaces.c >=20 > Modified: head/contrib/bsnmp/snmp_mibII/mibII.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/contrib/bsnmp/snmp_mibII/mibII.c Thu Jan 21 15:27:44 2016 (r2945= 06) > +++ head/contrib/bsnmp/snmp_mibII/mibII.c Thu Jan 21 16:11:20 2016 (r2945= 07) > @@ -443,6 +443,7 @@ mib_fetch_ifmib(struct mibif *ifp) > size_t len; > void *newmib; > struct ifmibdata oldmib =3D ifp->mib; > + struct ifreq irr; > =20 > if (fetch_generic_mib(ifp, &oldmib) =3D=3D -1) > return (-1); > @@ -514,6 +515,18 @@ mib_fetch_ifmib(struct mibif *ifp) > } > =20 > out: > + strncpy(irr.ifr_name, ifp->name, sizeof(irr.ifr_name)); Why not strlcpy? You're not forcing null termination here, so there could be issues. Thanks, --=20 Shawn Webb HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWoQ1iAAoJEGqEZY9SRW7uQBoQAKhhmF/Z4L/pgC+g5DPPvPoB Caw35GG1avNuty0mwGXK7ASHKCj8BbN+e80XKSYNlB11ZutfnRU4q6IJNs0wWit/ dFzrlqeFSLluKf6o+RvMymE0SXNZg9FiYScckRJy69NuDnJm+1o7xtlKpegPi5yu 799cL/9kxWnj1VfbJHzHuCVHR13+rjEAXquRd4kJe+vREPpYm2bvFOQJXIy1ABVl otua4E1UqCQ1ZZNJ14daWv6H9+YMF5RjIRCk1BGAf7PctoD2EMPJfcQOrpg4kxB7 WoDCrAGtcaSqAfVOtyMnb/5M5tz67aCFg7iQ+apPegcspkAiyyTrOUjHtNw9dEnk 2Q4L88+rBDFZjPe3HYkB6a4+CXo6wTiRtwqEL4epE39Idt5mqih5LuprkrwVNV4A RMz6v0yVtAAyig/sItvou5b0pRcmhYqbmqAy7VnQ5hNpEF9URwi9XoazfScrLGLI q+GUNl38klRGamSKoOhPlCjunLbM/2EUpQo6S9kar7q7MiCdWVsD1kO2DvBA1SMN OHO0m0lMiajWBlsi3+YFJbQ/9yZ17uXkLDL2PtE4SgWAqWW4z93i/5PXZd0R6vdn wJut8wZtu9oGiEQkqKm/+c16NBqc446IK4IEKN5Ux8rK9SlOTpKi0MAVAFhtcHfw InaSB6g5uzGQZNt27JXq =ogKw -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--