From owner-svn-src-all@freebsd.org Thu Mar 3 11:33:36 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F255A93DDE; Thu, 3 Mar 2016 11:33:36 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EEE2A71; Thu, 3 Mar 2016 11:33:35 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (unknown [62.141.129.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 4933B1FE022; Thu, 3 Mar 2016 12:33:29 +0100 (CET) Subject: Re: svn commit: r296320 - in head/sys: kern sys To: Konstantin Belousov References: <201603021846.u22IkHWM010861@repo.freebsd.org> <56D81918.6020403@selasky.org> <20160303112716.GO67250@kib.kiev.ua> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Hans Petter Selasky Message-ID: <56D821A7.2020105@selasky.org> Date: Thu, 3 Mar 2016 12:36:07 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160303112716.GO67250@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 11:33:36 -0000 On 03/03/16 12:27, Konstantin Belousov wrote: >> >BTW: The FreeBSD kernel version should have been bumped because >> >_callout_stop_safe() is a public callout API, used by all external >> >kernel modules, which now will have undefined behaviour until recompiled. > The change was done in a way which is compatible with the pre-commit > callout_stop_safe(9) users. I even consider it mergeable into the > stable/10 without requiring any shims. > > Yes, your change is compatible if you compile the code, but not binary compatible. See the following macros, and how they use _callout_stop_safe(): #define callout_stop(c) _callout_stop_safe(c, 0, NULL) #define callout_async_drain(c, d) \ _callout_stop_safe(c, 0, d) Because callout_stop(c) is a macro, you've now change the API for callout_stop() aswell. This is what I think will break binary compatibility in 10.x. That's why the need to bump __FreeBSD_version__ --HPS