From nobody Thu May 8 19:47:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZtjMZ6nqCz5vXJq; Thu, 08 May 2025 19:47:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZtjMZ5wbMz3DSJ; Thu, 08 May 2025 19:47:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746733642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WnI2Oupe3EAS7Uf1ZmlTtwuaGGEq3lr40PbuoiJ0SV8=; b=G0nCKwJShMshivZIWNIg7M3QdI9A/aLksLPj/F/UdBU45k7uaFiKpRmiHfhpjlf9728+3C u+fGfs+xUAwB7iO1GBkXfo+HHAqLPbjikIlTVQGk0evuQp14UnG2Qn/bzvjTPp/08Jg2AC 3WUsVoH/BUFiwqtK1Nid+/tM+x0wgyPLwEf9TFf1hTIGpkUXsCNxDQUgPDbfrFJ8EaMu8i H0pEvjVEkCHFHq3p6VrJd10OD8vbr6PJcbLZY/3VVsaAC1pXX+tbDbwuJ9ZJu4iqJvY517 1Y2joP/ZsAW9sIFN5IQTn4dXsdTd7cZK2wONEBANQyHim3/BB5MiHEVl+5bttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746733642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WnI2Oupe3EAS7Uf1ZmlTtwuaGGEq3lr40PbuoiJ0SV8=; b=FADD7Lnm6QBdmQhzgstwgyw9jnJ493gY+wWm8G45PTE/FnIumk7OuSwcqC8+l682HBkU4g +H49ipi6k2TYPc/1bOACQcwC5LTsQI8UOB3Kc5HyDL9ta33fn8n0oPPjgwOO7y5PgURD03 xCKJRSW7FuUwCMHlsr6JPsRbhLbev+BeaWXyA7ibmgG3qEWzjNVS+THI0CKthyTAyWUZRY sx3TzXS8RxLTgNO0vZvqy6eRHW01R+P6NrdhyHcITQTuhgnpAxicLLEpDwV4z+zUbarUnR eZnTA89wvO7XUs4vSpWOI+qUZVjPfpU7I7FOE682zt5pUnG3c9UCv384gjk/FQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746733642; a=rsa-sha256; cv=none; b=fA+DzRkULNP9HCdoMq7H6sk5+c0rPWgkTfd7gEtzbm2xqyNDnY8oDfBEWlPJfsVaGLe/tZ o6D7fl0/2985ssNrs5f4hXi7dAU7AUY5kfPw12eM5pvVb1Job2jTm5v3yBPj1kOeu+fwrR nooJ/LMAInjQ0Z79+6pLJCEZXCwlT2fRwdLl7N5a3P9r4PknOR10/Z25RW/ReakLXAKWj3 bVjQPHLXfKZDpv/cqjRxSzbrXwPzpNqJDUfwAM278DdLcXeekrQRebYs01oXgns6+fgmZT n8ffIi7me5hU9yq3ljvRtMb3JQ+MiLObYjn3KErWOcmJ1sl+y6vMG+yYxDFpzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZtjMZ4tRmzDHW; Thu, 08 May 2025 19:47:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 548JlMqs086833; Thu, 8 May 2025 19:47:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 548JlM93086830; Thu, 8 May 2025 19:47:22 GMT (envelope-from git) Date: Thu, 8 May 2025 19:47:22 GMT Message-Id: <202505081947.548JlM93086830@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 78661696e639 - main - loader: i386: use -z nostart-stop-gc for bfd as well List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 78661696e639836c9c41313020308f132057189a Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=78661696e639836c9c41313020308f132057189a commit 78661696e639836c9c41313020308f132057189a Author: Kyle Evans AuthorDate: 2025-05-08 19:47:16 +0000 Commit: Kyle Evans CommitDate: 2025-05-08 19:47:16 +0000 loader: i386: use -z nostart-stop-gc for bfd as well binutils 2.37 seems to have added the knob, so let's just use that version here (it's not clear if GC'ing start/stop symbols was actually made the default at the time, and it didn't seem worth it to dig much further). This fixes misbehavior when built with more recent binutils, as we do rely on linker sets for loader commands that we use. Reported by: sjg Reviewed by: dim, sjg Differential Revision: https://reviews.freebsd.org/D50252 --- stand/i386/loader/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stand/i386/loader/Makefile b/stand/i386/loader/Makefile index bb9111c3dcce..e1f0298403b3 100644 --- a/stand/i386/loader/Makefile +++ b/stand/i386/loader/Makefile @@ -90,7 +90,8 @@ ORG= 0x0 CFLAGS+= -Wall LDFLAGS+= -static ${LDFLAGS_ORG} -Wl,--gc-sections -.if ${LINKER_TYPE} == "lld" && ${LINKER_VERSION} >= 130000 +.if (${LINKER_TYPE} == "lld" && ${LINKER_VERSION} >= 130000) || \ + (${LINKER_TYPE} == "bfd" && ${LINKER_VERSION} >= 23700) # lld 13 and higher default to garbage collecting start/stop symbols, # completely ruining our linker sets. For now, work around it by # disabling this un-feature.