From owner-svn-src-projects@FreeBSD.ORG  Wed Feb  6 16:33:02 2013
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 71E7A1C3;
 Wed,  6 Feb 2013 16:33:02 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 4F3947B1;
 Wed,  6 Feb 2013 16:33:02 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9FBB9B91E;
 Wed,  6 Feb 2013 11:33:01 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Alfred Perlstein <bright@mu.org>
Subject: Re: svn commit: r246380 - projects/cider/usr.bin/make
Date: Wed, 6 Feb 2013 10:14:35 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <201302060436.r164awc3073100@svn.freebsd.org>
 <CAF6rxg=vW2cFTkdmz3Tcf28LJ-eYU7u1MaDhu7eQYN2A3TSEuA@mail.gmail.com>
 <51125D8C.3050405@mu.org>
In-Reply-To: <51125D8C.3050405@mu.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201302061014.35619.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 06 Feb 2013 11:33:01 -0500 (EST)
Cc: svn-src-projects@freebsd.org, Alfred Perlstein <alfred@freebsd.org>,
 Eitan Adler <eadler@freebsd.org>, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2013 16:33:02 -0000

On Wednesday, February 06, 2013 8:41:32 am Alfred Perlstein wrote:
> On 2/5/13 8:40 PM, Eitan Adler wrote:
> > On 5 February 2013 23:36, Alfred Perlstein <alfred@freebsd.org> wrote:
> >> Author: alfred
> >> Date: Wed Feb  6 04:36:57 2013
> >> New Revision: 246380
> >> URL: http://svnweb.freebsd.org/changeset/base/246380
> >>
> >> Log:
> >>    Add headers needed to compile on OS X 10.7.5.
> > Please make sure to annotate that these headers are required on
> > !FreeBSD otherwise they may be removed if someone does a "include what
> > you use" run.
> >
> >
> Is there an existing way of doing this?
> 
> I'm not sure if I should just do
> #ifndef __FreeBSD__
> or something else?

In this particular case I would be inclined to instead do something like:

Makefile:
.if defined(BOOTSTRAPPING_OSX)
CFLAGS+= -include osx_bootstrap.h
.endif

osx_bootstrap.h:
#include <sys/types.h>
#include <stdint.h>

Doesn't hurt to just include those while building all of make I think and
that is a less invasive change.

-- 
John Baldwin