Date: Fri, 10 Jun 2022 20:50:25 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 53aec4c8cab1 - main - databases/tarantool: Depend on a specific version of devel/msgpuck. Message-ID: <CAMHz58R1nkPrjgDdr=-M9EEsktDpbpUqD63hkNTTB5dc9Cc4Fg@mail.gmail.com> In-Reply-To: <202206101239.25ACdhAx024843@gitrepo.freebsd.org> References: <202206101239.25ACdhAx024843@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f896cf05e11763f8 Content-Type: text/plain; charset="UTF-8" Hi, On Fri, Jun 10, 2022 at 8:39 PM Gleb Popov <arrowd@freebsd.org> wrote: > The branch main has been updated by arrowd: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=53aec4c8cab1306efeabf80d6841953515d3be57 > > commit 53aec4c8cab1306efeabf80d6841953515d3be57 > Author: Pavel Balaev <balaev@tarantool.org> > AuthorDate: 2022-06-10 12:38:15 +0000 > Commit: Gleb Popov <arrowd@FreeBSD.org> > CommitDate: 2022-06-10 12:38:15 +0000 > > databases/tarantool: Depend on a specific version of devel/msgpuck. > > The last msgpuck release introduced an ABI change, but did not bump > .so version. > --- > databases/tarantool/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/databases/tarantool/Makefile b/databases/tarantool/Makefile > index 05f808fb8ae0..d2263ad82338 100644 > --- a/databases/tarantool/Makefile > +++ b/databases/tarantool/Makefile > @@ -2,6 +2,7 @@ > > PORTNAME= tarantool > PORTVERSION= 2.10.0 > +PORTREVISION= 1 > CATEGORIES= databases > MASTER_SITES= https://download.tarantool.org/tarantool/src/ > > @@ -16,12 +17,13 @@ BROKEN_riscv64= fails to compile: > mmintrin.h:50:12: invalid conversion between > NOT_FOR_ARCHS= armv6 powerpc64 sparc64 > NOT_FOR_ARCHS_REASON= fails to build: Unsupported architecture > > -BUILD_DEPENDS= gsed:textproc/gsed > +BUILD_DEPENDS= gsed:textproc/gsed \ > + ${RUN_DEPENDS} > LIB_DEPENDS= libcurl.so:ftp/curl \ > libicui18n.so:devel/icu \ > - libmsgpuck.so:devel/msgpuck \ > libyaml.so:textproc/libyaml \ > libzstd.so:archivers/zstd > +RUN_DEPENDS= msgpuck>=2.0_4:devel/msgpuck > Thanks for adding the check but I would do it in a different way. The simplest solution is to add "msgpuck>=2.0_4:devel/msgpuck" to BUILD_DEPENDS. Besides, since tarantool link against libmsgpuck.so, it is better to use LIB_DEPENDS instead of BUILD_DEPENDS+RUN_DEPENDS. Regards, sunpoet --000000000000f896cf05e11763f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote"><div dir=3D"l= tr" class=3D"gmail_attr">On Fri, Jun 10, 2022 at 8:39 PM Gleb Popov <<a = href=3D"mailto:arrowd@freebsd.org">arrowd@freebsd.org</a>> wrote:<br></d= iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord= er-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has be= en updated by arrowd:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D53aec4c8cab1306= efeabf80d6841953515d3be57" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D53aec4c8cab1306efeabf80d6841953515d3be57</= a><br> <br> commit 53aec4c8cab1306efeabf80d6841953515d3be57<br> Author:=C2=A0 =C2=A0 =C2=A0Pavel Balaev <<a href=3D"mailto:balaev@tarant= ool.org" target=3D"_blank">balaev@tarantool.org</a>><br> AuthorDate: 2022-06-10 12:38:15 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Gleb Popov <arrowd@FreeBSD.org><br> CommitDate: 2022-06-10 12:38:15 +0000<br> <br> =C2=A0 =C2=A0 databases/tarantool: Depend on a specific version of devel/ms= gpuck.<br> <br> =C2=A0 =C2=A0 The last msgpuck release introduced an ABI change, but did no= t bump .so version.<br> ---<br> =C2=A0databases/tarantool/Makefile | 6 ++++--<br> =C2=A01 file changed, 4 insertions(+), 2 deletions(-)<br> <br> diff --git a/databases/tarantool/Makefile b/databases/tarantool/Makefile<br= > index 05f808fb8ae0..d2263ad82338 100644<br> --- a/databases/tarantool/Makefile<br> +++ b/databases/tarantool/Makefile<br> @@ -2,6 +2,7 @@<br> <br> =C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 tarantool<br> =C2=A0PORTVERSION=3D=C2=A0 =C2=A02.10.0<br> +PORTREVISION=3D=C2=A0 1<br> =C2=A0CATEGORIES=3D=C2=A0 =C2=A0 databases<br> =C2=A0MASTER_SITES=3D=C2=A0 <a href=3D"https://download.tarantool.org/taran= tool/src/" rel=3D"noreferrer" target=3D"_blank">https://download.tarantool.= org/tarantool/src/</a><br> <br> @@ -16,12 +17,13 @@ BROKEN_riscv64=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0fails to compile: mmintrin.h:50:12: invalid conversion between<br= > =C2=A0NOT_FOR_ARCHS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0armv6 powerpc64 spa= rc64<br> =C2=A0NOT_FOR_ARCHS_REASON=3D=C2=A0 fails to build: Unsupported architectur= e<br> <br> -BUILD_DEPENDS=3D gsed:textproc/gsed<br> +BUILD_DEPENDS=3D gsed:textproc/gsed \<br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${RUN_DEPENDS}<br> =C2=A0LIB_DEPENDS=3D=C2=A0 =C2=A0libcurl.so:ftp/curl \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libicui18n.so:devel= /icu \<br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libmsgpuck.so:devel= /msgpuck \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libyaml.so:textproc= /libyaml \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libzstd.so:archiver= s/zstd<br> +RUN_DEPENDS=3D=C2=A0 =C2=A0msgpuck>=3D2.0_4:devel/msgpuck<br></blockquo= te><div><br></div><div>Thanks for adding the check but I would do it in a d= ifferent way.</div><div>The simplest solution is to add "msgpuck>= =3D2.0_4:devel/msgpuck" to BUILD_DEPENDS.</div><div>Besides, since tar= antool link against=C2=A0libmsgpuck.so, it is better to use LIB_DEPENDS ins= tead of BUILD_DEPENDS+RUN_DEPENDS.<br></div><div><br></div><div>Regards,</d= iv><div>sunpoet</div></div></div> --000000000000f896cf05e11763f8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58R1nkPrjgDdr=-M9EEsktDpbpUqD63hkNTTB5dc9Cc4Fg>