Date: Fri, 10 Jun 2022 16:01:07 +0300 From: Gleb Popov <arrowd@freebsd.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 53aec4c8cab1 - main - databases/tarantool: Depend on a specific version of devel/msgpuck. Message-ID: <CALH631n3ebNQ6Hchg5Q8AM_cEZG_RbLxUH7QO1deY_r37Y%2BWyQ@mail.gmail.com> In-Reply-To: <CAMHz58R1nkPrjgDdr=-M9EEsktDpbpUqD63hkNTTB5dc9Cc4Fg@mail.gmail.com> References: <202206101239.25ACdhAx024843@gitrepo.freebsd.org> <CAMHz58R1nkPrjgDdr=-M9EEsktDpbpUqD63hkNTTB5dc9Cc4Fg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000be2c1505e1178924 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 10, 2022 at 3:51 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > Hi, > > Thanks for adding the check but I would do it in a different way. > The simplest solution is to add "msgpuck>=2.0_4:devel/msgpuck" to > BUILD_DEPENDS. > Besides, since tarantool link against libmsgpuck.so, it is better to use > LIB_DEPENDS instead of BUILD_DEPENDS+RUN_DEPENDS. > > Regards, > sunpoet > Hum. Yes, that indeed makes more sense. Will do it rn. --000000000000be2c1505e1178924 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jun 10, 2022 at 3:51 PM Po-Ch= uan Hsieh <<a href=3D"mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a= >> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px= 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di= v dir=3D"ltr"><div>Hi,</div><div class=3D"gmail_quote"><div><br></div><div>= Thanks for adding the check but I would do it in a different way.</div><div= >The simplest solution is to add "msgpuck>=3D2.0_4:devel/msgpuck&qu= ot; to BUILD_DEPENDS.</div><div>Besides, since tarantool link against=C2=A0= libmsgpuck.so, it is better to use LIB_DEPENDS instead of BUILD_DEPENDS+RUN= _DEPENDS.<br></div><div><br></div><div>Regards,</div><div>sunpoet</div></di= v></div></blockquote><div><br></div><div>Hum. Yes, that indeed makes more s= ense. Will do it rn.<br></div></div></div> --000000000000be2c1505e1178924--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631n3ebNQ6Hchg5Q8AM_cEZG_RbLxUH7QO1deY_r37Y%2BWyQ>