From owner-svn-src-all@freebsd.org Thu Feb 6 18:31:27 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1CE6233635; Thu, 6 Feb 2020 18:31:27 +0000 (UTC) (envelope-from pawel.biernacki@gmail.com) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48D6TB4chmz4Pbd; Thu, 6 Feb 2020 18:31:26 +0000 (UTC) (envelope-from pawel.biernacki@gmail.com) Received: by mail-lj1-x235.google.com with SMTP id v17so7181574ljg.4; Thu, 06 Feb 2020 10:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2pySyBOffS6Rk8g1h5Jni6VtF9XTRLxus5pSr6zuX34=; b=gysNMDPLGQdpPWO3GtfnZksaOZL0iraN0lQDUxEhZRTGHy3XfvPVY0jXvP1Pu+JFCq N8ywYPI/vChyxUg8oEYI3ZW3prJqWMEBpKiLPC7wcZNnpmxkvMxaSxJdD/LTCWvRgcmC 895pSAc3SkhlOYRQ+mVb6DzKBPx5qb+N2dodAfsCC9cbAa/g4N/BXLQsd7CsTbTgYJSh rLVlVeFXjAHiGVbGkx1VJohLPGcPFTws0TIgdAg6JuHXe5GmC4ja2Ue6I0PQdiW7ZmVE Ybq0sIohp0hf4xiGbxIb/rhsnr1RAFHM+TrK/8rIlQ3CFNWgi50Rwbjwd18btiD9nYHC x73w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2pySyBOffS6Rk8g1h5Jni6VtF9XTRLxus5pSr6zuX34=; b=f0cyOJ1kDJp6g3kJ4MOAw9DCbwumsC3F7T7nHP8dz6YbnoQungymM+q2Gx5dP03R+q WDRyo9oFiulBEbU0+IJlQu0kJnaYuUEQUgIuLcVTvYrgFPLawgqRx9Esg9OZFToO1X5B ieDVBo0M/3/kVklMzf7jBmGvlczxuufWalPppCe4MHhFnQW9h3otXf1i6FQh3GTXEw27 247/7Wm0zIL8WcKdYQuG4vFnQPrqJbPoGz2G8SNiN++laVeiwyNCpkDiHIgUI4RjNzbO lM3PI4Ne/u85+4PUoPB98UWT4Jna8sG+aDzIAqLth9cG2010KLNpji8edNaHHAZpMbna jl8Q== X-Gm-Message-State: APjAAAVijMSxx6L2mEkdh47nATgb7rhKMMN57DIXPAWr0p+tw/w9sfX9 3C3fA5zEfa26Ffh35boMgFMaT95wuDE= X-Google-Smtp-Source: APXvYqwJnHWLYq228W4mTHohxd4cQDuH8xImkOtu4WrewI8APqz+yzx0Yh8Rpf3biXxeTYvdTYly+A== X-Received: by 2002:a2e:b04b:: with SMTP id d11mr2881710ljl.248.1581013884331; Thu, 06 Feb 2020 10:31:24 -0800 (PST) Received: from [172.20.0.153] (193-106-244-222.noc.fibertech.net.pl. [193.106.244.222]) by smtp.gmail.com with ESMTPSA id a8sm54675ljn.74.2020.02.06.10.31.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Feb 2020 10:31:23 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r357614 - in head/sys: kern sys From: =?utf-8?Q?Pawe=C5=82_Biernacki?= In-Reply-To: Date: Thu, 6 Feb 2020 19:31:22 +0100 Cc: Pawel Biernacki , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <98C8A90D-84F5-4E10-B982-DDF95B8912D2@gmail.com> References: <202002061245.016CjwTi096374@repo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48D6TB4chmz4Pbd X-Spamd-Bar: +++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=gysNMDPL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of pawelbiernacki@gmail.com designates 2a00:1450:4864:20::235 as permitted sender) smtp.mailfrom=pawelbiernacki@gmail.com X-Spamd-Result: default: False [5.78 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(5.00)[222.244.106.193.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.4]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.52)[-0.515,0]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-9.39), ipnet: 2a00:1450::/32(-2.49), asn: 15169(-1.74), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.80)[0.797,0]; RCVD_IN_DNSWL_NONE(0.00)[5.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2020 18:31:27 -0000 Thanks, will be fixed before enabling it. > On 6 Feb 2020, at 17:41, Hans Petter Selasky wrote: >=20 > On 2020-02-06 13:45, Pawel Biernacki wrote: >> +#ifdef notyet >> +#define SYSCTL_ENFORCE_FLAGS(x) = \ >> + _Static_assert(((CTLFLAG_MPSAFE ^ CTLFLAG_NEEDGIANT) & (x)), = \ >> + "Has to be either CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT") >> +#else >> +#define SYSCTL_ENFORCE_FLAGS(x) >> +#endif >=20 > Like cem@ pointed out, either you expand the XOR via OR or you can = also do it like this: >=20 > (((x) & CTLFLAG_MPSAFE) !=3D 0) ^ (((x) & CTLFLAG_NEEDGIANT) !=3D 0) >=20 > which avoids having to define another macro. >=20 > --HPS