From nobody Mon Dec 1 15:18:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dKnbP3sp4z6JjkL; Mon, 01 Dec 2025 15:18:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dKnbP2sK6z3Pq2; Mon, 01 Dec 2025 15:18:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764602289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXKQvGpQ92xj5H1i7pigcZi5BGrdnF6n7xIc3KcpX/k=; b=CkR5ytAAxLW2qTNuo+HDyK8AUZmp/0PDP9ONGVQAfhnhW+3zEyl5hcyPhvGsuc6E14/BEN +1XuvM+eAVwi9stHyxX/IJ6vIXLcrOszazkl6L8qfgJHBesr2KNLUT8yRi40s+N1FkTDCI Z4RdwEkTRb/oQ/ycKMz/p+a4bR6hGvkmIdOJmCRoB6Ur2Oige6BOe+osG0LKS2nnx66wZ/ vw8MM7qM3zGcLqPDy1OVYaO+0OoZpqea0oY0G2xw97hsaRzE3maK1/ZOq29HGNU4IW5Jx5 DZGiYMUkT++cgSB5xAkWOpGuLZUdPV70T7YL/eOfEUrWFVZYJhRpEnXiQNfVDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764602289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXKQvGpQ92xj5H1i7pigcZi5BGrdnF6n7xIc3KcpX/k=; b=Wx2ElfEgxpsPZtB+lhz+roX7fRq+nZwk59LHcguSUU1ACgSmCM+GQ0FWDFEIjMKjMl0T/W G+J0CM8wNMMmG4r4JnJSX8nz5HZDyGS16jAdfWcuzQYEDGwDvRrPja1oxvU4asEgTjd587 pU7eojdvFR6r8MOFp101MIhj03jZxCfJddn0n3r0D4xDjEGB7k90Sow5Zaz9e3tRwCuDZM DDIYEpDg9H0H1IuLmHyCCVBNp2u0idzMUVLGE7BHW472aBpt4IQO2NyAGU7xYbfMeKqfNy ol17xE7hT6LHkRFomLXeHz8vsDjOct3dQKqv2WOSWR2vNRTGMsF8To76PCoL9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764602289; a=rsa-sha256; cv=none; b=yyTPdbyGEMTg3srzq4pFbDEzHXkeaIsuTwSKViovujnbCCeNS895KEeEFtU5Z1jsH4DXmY dQUb3JqgtPGKnOPDF7up1W1hM9jNhwtM6WguGVHD3FACPKSlMy01adyZinwmE2lfWmu5A5 pE241oPKFxMOyHHZ4AEALvg5OT+F5wd8m+ud2hqslzGOU/NspMXLCCnUXSJ1azwbpdFaPe fcbjlU6E8ppFuIOv//aQrptNKNGrO7OE7eOkG8+qsJGljhv0XslRRtMPHdsv4oGnhkZTzQ QgGSkoyq9RsntSw99HzowD0yc2LJGE8cIKgq1rZO9mAX1F7JBgEdV/TUJ1BRFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:4cbc:6bd:30e8:ed5d] (unknown [IPv6:2601:5c0:4202:5670:4cbc:6bd:30e8:ed5d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dKnbP0XR4z8Xh; Mon, 01 Dec 2025 15:18:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 1 Dec 2025 10:18:08 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f42421307b11 - main - sys: remove armv6/6.1 support from debug monitor Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Minsoo Choo References: <692a8ea7.feb1.63d10382@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <692a8ea7.feb1.63d10382@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/29/25 01:11, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f42421307b115345ea1a6c8fdf61fbb581e4400f > > commit f42421307b115345ea1a6c8fdf61fbb581e4400f > Author: Minsoo Choo > AuthorDate: 2025-11-29 00:34:40 +0000 > Commit: Warner Losh > CommitDate: 2025-11-29 04:56:36 +0000 > > sys: remove armv6/6.1 support from debug monitor > > Signed-off-by: Minsoo Choo > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1903 > --- > sys/arm/arm/debug_monitor.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) > > diff --git a/sys/arm/arm/debug_monitor.c b/sys/arm/arm/debug_monitor.c > index 7944becbae4d..4d61896a2142 100644 > --- a/sys/arm/arm/debug_monitor.c > +++ b/sys/arm/arm/debug_monitor.c > @@ -83,8 +83,6 @@ static uint32_t dbg_breakpoint_num; > #define ID_DFR0_CP_DEBUG_M_SHIFT 0 > #define ID_DFR0_CP_DEBUG_M_MASK (0xF << ID_DFR0_CP_DEBUG_M_SHIFT) > #define ID_DFR0_CP_DEBUG_M_NS (0x0) /* Not supported */ > -#define ID_DFR0_CP_DEBUG_M_V6 (0x2) /* v6 Debug arch. CP14 access */ > -#define ID_DFR0_CP_DEBUG_M_V6_1 (0x3) /* v6.1 Debug arch. CP14 access */ > #define ID_DFR0_CP_DEBUG_M_V7 (0x4) /* v7 Debug arch. CP14 access */ > #define ID_DFR0_CP_DEBUG_M_V7_1 (0x5) /* v7.1 Debug arch. CP14 access */ Humm, I would have probably left these as the register is still valid and I find it useful to describe the full range of values for registers that we define constants for. The rest of the removal certainly makes sense. > > @@ -594,10 +592,6 @@ dbg_enable_monitor(void) > dbg_dscr = cp14_dbgdscrint_get(); > > switch (dbg_model) { > - case ID_DFR0_CP_DEBUG_M_V6: > - case ID_DFR0_CP_DEBUG_M_V6_1: /* fall through */ > - cp14_dbgdscr_v6_set(dbg_dscr | DBGSCR_MDBG_EN); > - break; Should this function also be removed? Looks to be defined here in sys/arm/include/cpu.h: _WF1(cp14_dbgdscr_v6_set, CP14_DBGDSCRext_V6(%0)) -- John Baldwin