From owner-svn-src-all@FreeBSD.ORG Fri Nov 9 19:18:36 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C0F71F27; Fri, 9 Nov 2012 19:18:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 418F88FC0A; Fri, 9 Nov 2012 19:18:36 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qA9JIVY6066906; Fri, 9 Nov 2012 21:18:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-DKIM: OpenDKIM Filter v2.5.2 kib.kiev.ua qA9JIVY6066906 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qA9JIVK2066905; Fri, 9 Nov 2012 21:18:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 9 Nov 2012 21:18:31 +0200 From: Konstantin Belousov To: Dimitry Andric Subject: Re: svn commit: r242835 - head/contrib/llvm/lib/Target/X86 Message-ID: <20121109191831.GG73505@kib.kiev.ua> References: <201211091856.qA9IuRxX035169@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hSgrh6VlWhhGqruz" Content-Disposition: inline In-Reply-To: <201211091856.qA9IuRxX035169@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2012 19:18:36 -0000 --hSgrh6VlWhhGqruz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 09, 2012 at 06:56:27PM +0000, Dimitry Andric wrote: > Author: dim > Date: Fri Nov 9 18:56:27 2012 > New Revision: 242835 > URL: http://svnweb.freebsd.org/changeset/base/242835 >=20 > Log: > Reduce LLVM's default stack alignment for i386 from 16 to 4 bytes, as > the FreeBSD ABI requires. This is essentially a revert of upstream llvm > commit r126226, and it will be reverted by upstream too. > =20 > MFC after: 1 week >=20 > Modified: > head/contrib/llvm/lib/Target/X86/X86Subtarget.cpp >=20 > Modified: head/contrib/llvm/lib/Target/X86/X86Subtarget.cpp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/contrib/llvm/lib/Target/X86/X86Subtarget.cpp Fri Nov 9 18:23:38= 2012 (r242834) > +++ head/contrib/llvm/lib/Target/X86/X86Subtarget.cpp Fri Nov 9 18:56:27= 2012 (r242835) > @@ -416,12 +416,12 @@ X86Subtarget::X86Subtarget(const std::st > assert((!In64BitMode || HasX86_64) && > "64-bit code requested on a subtarget that doesn't support it!"= ); > =20 > - // Stack alignment is 16 bytes on Darwin, FreeBSD, Linux and Solaris (= both > - // 32 and 64 bit) and for all 64-bit targets. > + // Stack alignment is 16 bytes on Darwin, Linux and Solaris (both 32 a= nd 64 > + // bit) and for all 64-bit targets. > if (StackAlignOverride) > stackAlignment =3D StackAlignOverride; > - else if (isTargetDarwin() || isTargetFreeBSD() || isTargetLinux() || > - isTargetSolaris() || In64BitMode) > + else if (isTargetDarwin() || isTargetLinux() || isTargetSolaris() || > + In64BitMode) > stackAlignment =3D 16; > } > =20 Great, thank you for taking care of this. --hSgrh6VlWhhGqruz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCdVwcACgkQC3+MBN1Mb4gnBQCgpycCgPxe9LwwdYAGDZDk600P EsgAoMs9CuQzXGo5N6vcnvFNR8Md0qH+ =IbZs -----END PGP SIGNATURE----- --hSgrh6VlWhhGqruz--