From owner-svn-src-head@freebsd.org Sat Jul 28 21:45:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EDEF105F890; Sat, 28 Jul 2018 21:45:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D668C82993; Sat, 28 Jul 2018 21:45:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w6SLjNFu031570 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 29 Jul 2018 00:45:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w6SLjNFu031570 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w6SLjNeI031568; Sun, 29 Jul 2018 00:45:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 29 Jul 2018 00:45:23 +0300 From: Konstantin Belousov To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336835 - head/lib/libc/gen Message-ID: <20180728214523.GC40119@kib.kiev.ua> References: <201807281908.w6SJ80qo089859@repo.freebsd.org> <20180728200611.GA40119@kib.kiev.ua> <20180728203253.GB40119@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2018 21:45:34 -0000 On Sat, Jul 28, 2018 at 01:59:16PM -0700, Conrad Meyer wrote: > On Sat, Jul 28, 2018 at 1:32 PM, Konstantin Belousov > wrote: > > Our existing practice is to not provide an advise in the man pages > > for the userspace code which would harm the portability or the standard > > conformance. > > Perhaps, but you do not have to look beyond this manual page to find > that such a practice, if it is even nominally applied, is not followed > consistently. The remainder of the document spells the terminating > value as plain "NULL." FreeBSD manual pages consistently refer to > NULL as a pointer value. > > The Linux manual page spells the terminating value (char *)NULL and > explicitly documents why. That is perhaps both pedantically correct > and clear. I am amenable to such a change. I do not see much difference between (char *)0 and (char *)NULL. Both are better there, because both are correct. If you prefer (char *)NULL, please use it. > > > I am not so sure about CheriBSD, for instance. > > I observe simply that CheriBSD is not FreeBSD and that CHERI is an > exotic architecture. We should not give an advise which breaks other architectures, even if not included into the mainline repo.