From owner-p4-projects@FreeBSD.ORG  Sun Apr 24 16:21:45 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5C00B16A4D0; Sun, 24 Apr 2005 16:21:45 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3517D16A4CE
	for <perforce@freebsd.org>; Sun, 24 Apr 2005 16:21:45 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E522643D1D
	for <perforce@freebsd.org>; Sun, 24 Apr 2005 16:21:44 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j3OGLiYc092443
	for <perforce@freebsd.org>; Sun, 24 Apr 2005 16:21:44 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j3OGLiHT092440
	for perforce@freebsd.org; Sun, 24 Apr 2005 16:21:44 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sun, 24 Apr 2005 16:21:44 GMT
Message-Id: <200504241621.j3OGLiHT092440@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 75890 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2005 16:21:46 -0000

http://perforce.freebsd.org/chv.cgi?CH=75890

Change 75890 by rwatson@rwatson_paprika on 2005/04/24 16:20:44

	Answer the question in the comment as to whether au_free_token()
	should be a macro -- answer is no, because it's a defined part of
	the API/ABI as a symbol, and in order to keep the contents of the
	token structure out of the ABI, it has to be a function.
	
	Minor reformatting.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#4 (text+ko) ====

@@ -55,17 +55,16 @@
 
 /* 
  * This call frees a token_t and its internal data.  
- *
- * XXX  Should it be a macro for speed?  
  */
-void au_free_token(token_t *tok)
+void
+au_free_token(token_t *tok)
 {
-    if (tok)
-    {
+
+	if (tok != NULL) {
 		if (tok->t_data)
 			free(tok->t_data);
 		free(tok);
-    }
+	}
 }
 
 /*