From nobody Wed Aug 5 15:21:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYzN1KfFz6nR8m for ; Wed, 05 Aug 2026 15:21:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYzM5RGWz47TK for ; Wed, 05 Aug 2026 15:21:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WjAIdtg3T33fPP10P0ODaE46nDZJq35ftt+hd9ez1w=; b=tIMziP4tO2DDgOuv5RYMgV8wpwG9jt/HRZeeR76JDaeefnYVadYX34/0g5bqTAE2+pG0BX D08+j3rSidzDBObwqAdzLQaZ4O0e95na6dAz/AIu3JICBIxi7l4d80Ew43Mw+z2enzhGCD 8fXWblRL4nATwz/h7lG+si0NA6/z9FHL/q9F/0C3TAHGvPfHP86eo3tYuBGzDRmptePRQQ 3XmrXnKyS+gxRpg0Di8pr9pppkCFMQiTf6oEuCKZ2uCGZSmG3/ybhCYwmpWGbODc+2++67 GaxtCUPNiTB3LNYWN27DSC5W+vQLvF+XXSrQY7xJmTU9peFuqdI5DYdn4A8V7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785943295; a=rsa-sha256; cv=none; b=VB4sIt8J7lPQ9b1ZQDCSyLhAl5yJi/h7uu1ibCz/bNJ2p5uNTSwWKtJZDYMXSVpipPBO7g ye/Pq5Q3oqHjjn2EG39NO03Jlz6w+oWCOHxlQcNN8zAejkSrPxulfvyg7B3x9Cx7MOZUke c8cApLuY+vO2+5JX1Bxnuviw2QKNVUWKvR9IqleeMMizD3mYnqGcosRuoblafEttfb3Keb hfbXWNdayGZSuCf2M/dW+5kwNwZLDFM9SpPQvmvSMMwDUCVwhMe8N+yagKhTS3PBbG5ILh AK+6yqSvCDHpAL8KleYzHnMcri7pzebW0hb6WEP5AS8+W/FeR+4fp9U+47fs2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WjAIdtg3T33fPP10P0ODaE46nDZJq35ftt+hd9ez1w=; b=TrAiZH/WvOzUuSptyseuTMDE89OKKzb3FJcJ43EheqfPfrEJrz2d4vZF2wuCM1cYTV+fps cHLOxAe8pKRhLb9VXsK1KImaR2l8FRJUhOb3Ey6bkVgCgGC+qcd6TY0KaUAyA/aWdIrkK7 bnE0mh+Y6Fwrjunjnlzsvx8HHA6Tcj8NWXI7uvebDnHxO1a0LUgwc4p7ctvwWWmO3lNLvB a/bdmlKU83mr6oEN+k9EaSYuVax948YC3l4Ay5/yEC6nmE6wQm/p19czl1rZL7dVBYBPs2 H5DGH8qSu+YU9yG9XtYMF9wJnoH8eIusXVAQ6K4TtxEUHdcZ52g7+DOWgYSRkw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYzM2NTZzg8J for ; Wed, 05 Aug 2026 15:21:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4702b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:21:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 200de1b70e2b - main - rtadvd(8): Fix RA flag inconsistency messages List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 200de1b70e2b4f809d1d3a4c430db80b24124468 Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:21:30 +0000 Message-Id: <6a7354fa.4702b.516957b0@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=200de1b70e2b4f809d1d3a4c430db80b24124468 commit 200de1b70e2b4f809d1d3a4c430db80b24124468 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-08-05 08:27:54 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-08-05 15:20:04 +0000 rtadvd(8): Fix RA flag inconsistency messages During flag inconsistency report, we handle rai->rai_otherflg as a bool, but the value is 0x40. Make it a simple number comparison. PR: 295995 Reviewed by: markj, Faraz Vahedi MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58672 --- usr.sbin/rtadvd/rtadvd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/usr.sbin/rtadvd/rtadvd.c b/usr.sbin/rtadvd/rtadvd.c index b772f78845d8..1525c992a65b 100644 --- a/usr.sbin/rtadvd/rtadvd.c +++ b/usr.sbin/rtadvd/rtadvd.c @@ -1138,9 +1138,9 @@ ra_input(int len, struct nd_router_advert *nra, syslog(LOG_NOTICE, "M flag inconsistent on %s:" " %s from %s, %s from us", - ifi->ifi_ifname, on_off[!rai->rai_managedflg], + ifi->ifi_ifname, on_off[rai->rai_managedflg == 0], inet_ntop(AF_INET6, &from->sin6_addr, ntopbuf, - sizeof(ntopbuf)), on_off[rai->rai_managedflg]); + sizeof(ntopbuf)), on_off[rai->rai_managedflg != 0]); inconsistent++; } /* O flag */ @@ -1149,9 +1149,9 @@ ra_input(int len, struct nd_router_advert *nra, syslog(LOG_NOTICE, "O flag inconsistent on %s:" " %s from %s, %s from us", - ifi->ifi_ifname, on_off[!rai->rai_otherflg], + ifi->ifi_ifname, on_off[rai->rai_otherflg == 0], inet_ntop(AF_INET6, &from->sin6_addr, ntopbuf, - sizeof(ntopbuf)), on_off[rai->rai_otherflg]); + sizeof(ntopbuf)), on_off[rai->rai_otherflg != 0]); inconsistent++; } /* Reachable Time */