From owner-cvs-all Sat Jan 4 23:51:26 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1BD137B401; Sat, 4 Jan 2003 23:51:25 -0800 (PST) Received: from mta5.snfc21.pbi.net (mta5.snfc21.pbi.net [206.13.28.241]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5668D43EC2; Sat, 4 Jan 2003 23:51:25 -0800 (PST) (envelope-from hsu@FreeBSD.org) Received: from FreeBSD.org ([63.193.112.125]) by mta5.snfc21.pbi.net (iPlanet Messaging Server 5.1 HotFix 1.6 (built Oct 18 2002)) with ESMTP id <0H8800FABDTOMC@mta5.snfc21.pbi.net>; Sat, 04 Jan 2003 23:51:25 -0800 (PST) Date: Sat, 04 Jan 2003 23:52:16 -0800 From: Jeffrey Hsu Subject: Re: cvs commit: src/sys/netinet tcp_subr.c tcp_timer.c In-reply-to: Message from Pierre Beyssac "of Sun, 05 Jan 2003 08:22:10 +0100." <20030105072210.GA880@fasterix.frmug.org> To: Pierre Beyssac Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Message-id: <0H8800FACDTPMC@mta5.snfc21.pbi.net> MIME-version: 1.0 X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > This seems to reintroduce the panic at close() I fixed by revision > 1.31 of tcp_syncache.c. This is a new bug introduced by a bad interaction with rev 1.148 of tcp_subr.c, which set the inp to NULL. > On second thought, the following patch (also untested) keeping the > generation count check is probably safer in case the inpcb is reused > when we look at it. Yes, this is the correct fix for this problem. Jeffrey To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message