Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Dec 2011 21:53:56 +0000
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r228650 - head/usr.bin/netstat
Message-ID:  <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net>
In-Reply-To: <201112171721.pBHHLloU069166@svn.freebsd.org>
References:  <201112171721.pBHHLloU069166@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 17. Dec 2011, at 17:21 , Dimitry Andric wrote:

> Author: dim
> Date: Sat Dec 17 17:21:47 2011
> New Revision: 228650
> URL: http://svn.freebsd.org/changeset/base/228650
>=20
> Log:
>  In usr.bin/netstat/atalk.c, work around a clang false positive with
>  printf format warnings and conditional operators.
>=20

This does not sound like a good idea.  Make clang work.


>  MFC after:	1 week
>=20
> Modified:
>  head/usr.bin/netstat/atalk.c
>=20
> Modified: head/usr.bin/netstat/atalk.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/usr.bin/netstat/atalk.c	Sat Dec 17 17:04:30 2011	=
(r228649)
> +++ head/usr.bin/netstat/atalk.c	Sat Dec 17 17:21:47 2011	=
(r228650)
> @@ -81,7 +81,7 @@ static	char mybuf[50];
> 			return("*");
> 		}
> 	}
> -	sprintf(mybuf,"%hu",ntohs(sat->sat_addr.s_net));
> +	sprintf(mybuf,"%hu",(short)ntohs(sat->sat_addr.s_net));
> 	return mybuf;
> }
>=20

--=20
Bjoern A. Zeeb                                 You have to have visions!
         Stop bit received. Insert coin for new address family.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C98B8D8-99F6-4996-A0FB-C128D9384180>