From owner-svn-src-head@FreeBSD.ORG Sun Apr 12 13:39:28 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB8941065677; Sun, 12 Apr 2009 13:39:28 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.24]) by mx1.freebsd.org (Postfix) with ESMTP id 344AD8FC13; Sun, 12 Apr 2009 13:39:28 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qw-out-2122.google.com with SMTP id 9so1132427qwb.7 for ; Sun, 12 Apr 2009 06:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=WJ6s2xddIXj70uWR1s9Iq8MglkmIdvllXAa3SYu5wps=; b=DV2K7i2pexJ/TOjQTxgaghc7i5CUxWUFYdDazvhWwqpWq2cllG8OuuSlyN73oYybon 3cNvQ9WzPs2Pjx0pa6ZvE7l9ujNQRZ8bM9Dmj2brlKlPflA43WLS130dRzKWJWWuU0qm mrZ7vGqbAQ9QRmE95ccLYXdXQiI/D0o4jJPQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=Tiyebrz4+hQMS7zZKU9jGlCRRmp1FNz+ZpY2aSdpBlS8VE4t7i9vRI+GkA3cl3C7nY zmk9uWNIz7BWmtPFglm4X6MCyhZNOiOBnMD3XEGbxCTw8LvnFynnTsjf9GGpOF1IohiC i3p+n9wbvQKcK3su8biMGB5zS9CtcGKEzTRMQ= Received: by 10.224.45.134 with SMTP id e6mr5342302qaf.41.1239543567640; Sun, 12 Apr 2009 06:39:27 -0700 (PDT) Received: from kan.dnsalias.net (c-98-217-224-113.hsd1.ma.comcast.net [98.217.224.113]) by mx.google.com with ESMTPS id 7sm2923896qwf.29.2009.04.12.06.39.26 (version=SSLv3 cipher=RC4-MD5); Sun, 12 Apr 2009 06:39:27 -0700 (PDT) Date: Sun, 12 Apr 2009 09:39:21 -0400 From: Alexander Kabaev To: Christoph Mallon Message-ID: <20090412093921.37dbbdbe@kan.dnsalias.net> In-Reply-To: <49E1EB5A.9010303@gmx.de> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090411163528.GC46526@troutmask.apl.washington.edu> <20090411124335.0600a72f@kan.dnsalias.net> <49E1E01C.90704@gmx.de> <20090412090551.176f327c@kan.dnsalias.net> <49E1EB5A.9010303@gmx.de> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Dgmu+VP4gev7qlJ+PwrU5Hw"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten Subject: Re: svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 13:39:29 -0000 --Sig_/Dgmu+VP4gev7qlJ+PwrU5Hw Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 12 Apr 2009 15:23:38 +0200 Christoph Mallon wrote: > Alexander Kabaev schrieb: > > On Sun, 12 Apr 2009 14:35:40 +0200 > > Christoph Mallon wrote: > >=20 > >> Alexander Kabaev schrieb: > >>> On Sat, 11 Apr 2009 09:35:28 -0700 > >>> Steve Kargl wrote: > >>> > >>>> On Sat, Apr 11, 2009 at 02:01:01PM +0000, Ed Schouten wrote: > >>>>> Author: ed > >>>>> Date: Sat Apr 11 14:01:01 2009 > >>>>> New Revision: 190919 > >>>>> URL: http://svn.freebsd.org/changeset/base/190919 > >>>>> > >>>>> Log: > >>>>> Simplify in/out functions (for i386 and AMD64). > >>>>> =20 > >>>>> Remove a hack to generate more efficient code for port numbers > >>>>> below 0x100, which has been obsolete for at least ten years, > >>>>> because GCC has an asm constraint to specify that. > >>>>> =20 > >>>>> Submitted by: Christoph Mallon >>>>> de> > >>>>> > >>>> I thought Christoph and bde were still hashing out the > >>>> correctness of this patch. > >>>> > >>>> http://lists.freebsd.org/pipermail/freebsd-amd64/2009-April/012064.h= tml > >>>> > >>>> --=20 > >>>> Steve > >>> The patch is inconsistent in regards to usage of volatile vs. > >>> __volatile even within itself. I think the code is sloppy and was > >>> not ready to be committed yet. Please fix or back out. > >> Backing it out because of two underscores (!) would be=20 > >> counterproductive: It removes about 150 lines of hard to read > >> hacks, which are unnecessary for at least a decade. GCC 2.95, > >> which was released in 1999 supports the "N" constraint for inline > >> asm. Perhaps olders do, too, but you cannot get older GCCs from > >> the official site. Attached is a patch, which replaces all > >> __inline and __volatile in > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> the touched headers by thir ISO equivalents - again there hasn't > >> been > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> a reason to use the alternate GCC keywords for at least a decade. > >> Also "inline" and "volatile" are already used hundreds of times in > >> sys/. The patch is simply the result of > >> %s/\<__\(inline\|volatile\)\>/\1/. > >> > >> Christoph > >=20 > > Underscores as the sole reason for backing out might as well be > > counterproductive. The real objection was not about underscored > > though, but about consistency. Your patch was not consistent itself > > and it left files it touched with unholy mixture of plain and >=20 > We are all doomed! I can almost see the horsemen of apocalypse > appearing at the edge of the horizon! > You're a /tad/ histrionic. > Thank you for being so constructive. If little things like maintaining file consistency and adhering to established style are too strict and limit your creativity too much, maybe you should reconsider working on projects with > 1 person involved. =20 > > underscored versions sprinkled all over with no apparent system. > >=20 > > The way to handle this change was: > > 1. Prepare functional patch, commit. > > 2. Prepare underscore removal patch, commit. >=20 > Did you stop reading at the colon of the first sentence? I marked the=20 > relevant part above with "^". >=20 Should your patch today have stopped me from posting objection yesterday? I do appreciate your lecture on GCC versions and features that made code hacks obsolete. I would appreciate it even more it it was at lest tiny bit relevant to what I objected initially. --=20 Alexander Kabaev --Sig_/Dgmu+VP4gev7qlJ+PwrU5Hw Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iD8DBQFJ4e8NQ6z1jMm+XZYRAgb2AKDo5nOCLo4j96BmU6aDuK/feTvc5wCfYwaI BPZyqPO7J1ONy9zoFQOIk1g= =GvRz -----END PGP SIGNATURE----- --Sig_/Dgmu+VP4gev7qlJ+PwrU5Hw--