From owner-freebsd-mips@FreeBSD.ORG Tue Dec 28 21:07:21 2010 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94D571065670; Tue, 28 Dec 2010 21:07:21 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 510EA8FC1A; Tue, 28 Dec 2010 21:07:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id oBSL6A3i058840; Tue, 28 Dec 2010 14:06:10 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D1A5142.5090205@bsdimp.com> Date: Tue, 28 Dec 2010 14:06:10 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: Juli Mallett References: <4D1A1B83.5070602@bsdimp.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-mips@FreeBSD.org Subject: Re: [PATCH] Retrieval of TLS pointer via RDHWR X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2010 21:07:21 -0000 On 12/28/2010 13:37, Juli Mallett wrote: > On Tue, Dec 28, 2010 at 12:35, Robert Millan wrote: >> Thank you. So can it be committed, or does it need improvement >> of some kind first? > It seems to me that rather than waffling we should just commit it. > Assuming someone tests it and is confident in the implementation, I > can't see why they'd have a problem committing it. I reviewed the patch, and I liked it. Couldn't find anything wrong with it when I first looked at it. Would be nice if things were more flexible, but since generalizing from a sample size of one can be hard, I totally agree. Warner